Superfluid pool #292
Open
Superfluid pool #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2. rename IncDec to CFALib 3. implement payOwner function 4. add refund logic in burn function 5. limit TradableStream only transfer one time 6. add onlyOwner access control for payOwner and burn
2. convert Super token amount to underlying token amount
|
…to superfluid-pool
…to superfluid-pool
wisdant
reviewed
Feb 22, 2023
wisdant
reviewed
Mar 17, 2023
wisdant
reviewed
Mar 17, 2023
wisdant
reviewed
Mar 17, 2023
wisdant
reviewed
Mar 17, 2023
wisdant
reviewed
Mar 17, 2023
* code and one test * 1. add the limit to call fixed function mintToWithAuthorization 2. add msg.sender check 3. update tests * 1. add Multisend contract and tests 2. add permit function in TestToken 3. use block.chainid * remove owner and nonce parameter * deploy and verify new contracts about Superfluid * 1. update superfluid pool tests on mumbai 2. fix bugs of goerli superfluid pool scripts 3. create mumbai superfluid pool scripts 4. deploy, verify and validate superfluid pool contracts on mumbai * 1. refactor drawdownWithAuthorization function 2. remove drawdownWithReceivable function * update tests to borrow the same amount as NFT locked value * update based on review comments * remove Superfluid v1 contracts
2. use current flow rate instead of the initial flow rate when burn NFT
2. revert increasing/decreasing flows 3. revert creating new flow to processor 4. fix tests and add new tests
wisdant
reviewed
Apr 30, 2023
| address to, | ||
| int96 by | ||
| ) internal { | ||
| (, int96 curRate, , ) = _cfa.getFlow(token, from, to); |
There was a problem hiding this comment.
why is not permission check here?
wisdant
reviewed
Apr 30, 2023
| IConstantFlowAgreementV1 _cfa, | ||
| ISuperToken token, | ||
| address to, | ||
| int96 by |
There was a problem hiding this comment.
why do we use int96? would uint96 more clear and less error prone?
* superfluid processor event update * update deployed contracts on mumbai for superfluid * add unit test for settlement success event * update receivableCleared and settlementMade events * update deploy contract addresses --------- Co-authored-by: shan <[email protected]>
update receivableCleared and settlementMade events to include flowKey Co-authored-by: shan <[email protected]>
…#314) Co-authored-by: shan <[email protected]>
* Polish TradableStream.sol * comment out one skipped test * comment out logs in SuperfluidFactoringTest.sol * 1. update burn function permission 2. change require to revert errors in TradableStream contract * Added some comments --------- Co-authored-by: bin <[email protected]>
* add new tests
bin-57blocks
force-pushed
the
superfluid-pool
branch
from
ec42a26 to
1f823f8
Compare
1. replace Niflot to TradableStream 2. rename IncDec to CFALib 3. implement payOwner function 4. add refund logic in burn function 5. limit TradableStream only transfer one time 6. add onlyOwner access control for payOwner and burn implement a new version 1. remove unused IReceivableAsset interface 2. convert Super token amount to underlying token amount fix a permission issue of TradableStream burn add view functions add positive tests of Superfluid pool replace require messages to errors goerli deployment scripts fixing forking error remove forking for the whole hardhat network updated workflow file adding testing log add deployment validation script added env for testing added env for testing reverting debugging log add error code Borrow in one send (#298) * code and one test * 1. add the limit to call fixed function mintToWithAuthorization 2. add msg.sender check 3. update tests * 1. add Multisend contract and tests 2. add permit function in TestToken 3. use block.chainid * remove owner and nonce parameter * deploy and verify new contracts about Superfluid * 1. update superfluid pool tests on mumbai 2. fix bugs of goerli superfluid pool scripts 3. create mumbai superfluid pool scripts 4. deploy, verify and validate superfluid pool contracts on mumbai * 1. refactor drawdownWithAuthorization function 2. remove drawdownWithReceivable function * update tests to borrow the same amount as NFT locked value * update based on review comments * remove Superfluid v1 contracts add more tests conflict in yarn.lock Refactor ReceivableFactoringPool (#299) * 1. involve SuperApp framework 2. split SuperfluidPool to ReceivableFactoringPool and SuperfluidProcessor 3. implement drawdown function of SuperfluidProcessor * implement payoff function of SuperfluidPoolProcessor * add flow change logic * fix approveCredit and mintAndDrawdown tests * fix Superfluid tests 1. add logic to handle flow termination 2. add related tests 1. refactor SuperfluidPoolProcessor and TradableStream for adding logic in _handleFlowChange 2. add comments to describe options in _handleFlowChange 1. rename payoff to settlement 2. remove decreasing/increasing flow logic 3. revert transaction when decreasing/increasing flow 4. add tryTransferAllowance function 5. make settlement to be able called repeatedly 1. add new errors 2. add a new command 'gen-code-ids' 3. clean code add negative tests for mintToAndDrawdown 1. fix a bug of settlement 2. add negative tests for settlement 3. add more comments 1. update deployment scripts 2. deploy new contracts on mumbai 1. add comments to describe one limitation of flow terminatation 2. use current flow rate instead of the initial flow rate when burn NFT 1. add new logic to handle multiple borrowers of one flow termination 2. revert increasing/decreasing flows 3. revert creating new flow to processor 4. fix tests and add new tests add comments deploy new contracts about Superfluid deploy new contracts about Superfluid fix some small bugs superfluid processor event update (#306) * superfluid processor event update * update deployed contracts on mumbai for superfluid * add unit test for settlement success event * update receivableCleared and settlementMade events * update deploy contract addresses --------- Co-authored-by: shan <[email protected]> Superfluid pool event update (#311) update receivableCleared and settlementMade events to include flowKey Co-authored-by: shan <[email protected]> update receivableCleared and settlementMade events to include flowKey (#314) Co-authored-by: shan <[email protected]> 03 fine tune to Superfluid changes (#315) * Polish TradableStream.sol * comment out one skipped test * comment out logs in SuperfluidFactoringTest.sol * 1. update burn function permission 2. change require to revert errors in TradableStream contract * Added some comments --------- Co-authored-by: bin <[email protected]> New tests (#316) * add new tests
bin-57blocks
force-pushed
the
superfluid-pool
branch
from
1f823f8 to
8345d36
Compare
… burned while settlement function is called.
…to superfluid-pool
* fix merge conflicts * Superfluid SuperApp register support * remove old files * remove unused code * Add isSuperApp view function * Deploy and verify SuperfluidSuperAppRegister --------- Co-authored-by: shan <[email protected]>
fix decimals issue Co-authored-by: shan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.