Stuck notes when adding / playing notes in pattern editor with Calf Monosynth

[riban-bw]

Describe the bug
When a note is added to a pattern for Calf Monosynth it gets stuck on.

To Reproduce
Steps to reproduce the behaviour:

1. Add Calf Monosynth to a chain
2. Add a note to a pattern associated with the same MIDI channel

Expected behaviour
Note is added and played briefly.

Actual behaviour
Note is added and plays continually.

Setup:

• HARDWARE
  Raspberry Pi 4 Model B Rev 1.2
  Audio: Z2 ADAC
  Display: Z2 Display
  Wiring: Z2_V3
  I2C: MCP23017@0x20, MCP23017@0x21, ADS1115@0x48, ADS1115@0x49
• SYSTEM
  Raspbian GNU/Linux 10 (buster)
  Build Date: 2022-10-06
  Memory: 5% (220M/3838M)
  SD Card: 45% (13G/29G)
  Temperature: 44.8ºC
  Overclock: Maximum
• MIDI
  Profile: default.sh
  Tuning: 440 Hz
  Receive Mode: Stage (Omni On)
  ZS3 Sub-SnapShots: On
  MIDI to Output: Off
  Master Channel: 16
• SOFTWARE
  zyncoder: testing (2f62d59)
  zynthian-ui: testing (21ff4ca)
  zynthian-sys: testing (84ed19c)
  zynthian-data: testing (21d0966)
  zynthian-webconf: staging-2210 (b3cdde1)

Additional context
Also happens when note played from pattern editor keyboard. Okay for other instruments so may be an upstream issue but playing notes normally is okay.

[riban-bw]

Pattern editor sends note-on with velocity zero for note-off events which may be the cause of this issue.

I just tested and monosynth does not support note-on with velocity 0 for note-off messages.

[riban-bw]

I have reported the issue upstream: calf-studio-gear/calf#319.

We could work-around this by sending note-off in the pattern editor.

[riban-bw]

This also affects the playback of patterns, i.e. zynseq plays patterns with note-on+vel=0.

[jofemodo]

Is it also fixed for SMF player?
jackd input ports only accept unrolled midi (not running status), The docs say:

jack_midi_event_write(...)

Clients must not write more than data_size bytes into this buffer. Clients must write normalised MIDI data to the port - no running status and no (1-byte) realtime messages interspersed with other messages (realtime messages are fine when they occur on their own, like other messages).

[riban-bw]

It is now!