Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API inconsistency #15

Open
jecisc opened this issue Oct 27, 2018 · 0 comments
Open

API inconsistency #15

jecisc opened this issue Oct 27, 2018 · 0 comments

Comments

@jecisc
Copy link
Contributor

jecisc commented Oct 27, 2018

I thought we could create a unit value with the #value: message on units but apparently this is not consistent.

Unit m value: 1. "1 metre"

Unit g value: 15. "a DerivedUnit [grams]"
jecisc added a commit to jecisc/Units that referenced this issue Oct 27, 2018
@jecisc
Move base units from kilogram to gram and use prefix for kilogram.
be5e29c 
This commit also remove some duplicated code.

Fixes zweidenker#16 and Fixes zweidenker#15
@jecisc jecisc mentioned this issue Oct 27, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

16-comparing-grams-fails jecisc/Units
1 participant
@jecisc