-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How to work with non-cuboid layout prediction #25
Comments
Hello. Could you give me some advice to work well for non-cuboid layout prediction and how to modify panoOptimization.m ? |
@kazu0622 If you train with images of non-cuboid shape but with cuboid shape ground truth, your trained network will have cuboid predictions for all cases. I'd suggest you remove images with non-cuboid shape for training. For optimizing non-cuboid room shape, you need to:
|
Hello. Thank for your quick response! And thank you for sharing the information about "pano_line_solver_6.m". I've already tried this code, but it didn't work just replacing "pano_line_solver.m". Could you possibly tell us tip to work well? Thank you. |
@kazu0622 If your trained data are all cuboid shape, then it's still workable to predict non-cuboid corners and edges. You cannot just replace "pano_line_solver.m" with "pano_line_solver_6.m", since "pano_line_solver.m" assumes input of 8 corners and "pano_line_solver_6.m" assume input of 12 corners. You need to first initialize number of corners based on step 1 in #25 (comment) |
Thank you for your advice. I'd like to have your comment a little more that why pre-trained data "panofull_joint_box_pretrained.t7" didn't work on a non-cuboid images. Thank you. |
@zouchuhang Thank you for all your comment for my questions. Thank you. |
@kazu0622 "panofull_joint_box_pretrained.t7" is trained with images of both cuboid and non-cuboid shape, but all with cuboid shape ground truth. Thus for inference, given non-cuboid shape, it will predict cuboid results just as it learns from the training data. Therefore one solution could be to remove the non-cuboid shape training samples and retrain the network, so that the network might focusing on learning to label edges and corners, regardless of the room shape. You can play around with this strategy, and see if it takes affect. Otherwise, you can train with non-cuboid shape ground truth for non-cuboid sample. The pre-trained model I provide in #25 (comment) is trained with a mixture of cuboid shape (with cuboid gt) and non-cuboid shape (with non-cuboid gt) images, the network can thus be able to predict corners and edges for general Manhattan layout. You can play around with it. |
@zouchuhang I tried pre-trained model for non-cuboid layout you gave and use panofull_joint_ab_pretrained.t7 to import the model, but failed. It seems that the parameter counts doesn't match between the networkmodel and the pre-trained model. I'd like to know how to cope with this. Thank you. |
@kazu0622 As mentioned in #25 (comment), you need to exclude the 3D parameter regressor in the model since there're non-cuboid layouts now. |
@zouchuhang Thanks a lot! The non-cuboid prediction has worked. Before I try to import "pano_line_solver_6.m", I'm checking how it works. It seems that the manhattan line estimation work without processing both "mano_line_solver.m" and "pano_line_solver_6.m". But I've got an wrong room shape. I guess the roll of "pano_line_solver_6.m" is optimaizing the wrong shape. Is it natural I've got an wrong result without "pano_line_solver_6.m"? |
@kazu0622 The Manhattan Line estimation is a preprocessing step and is independent on the 3D reconstruction step. To better estimate room shape, please follow #25 (comment) "1. Determine whether to generate four, six or eight etc. walls by thresholding the score of the sixth strongest wall-wall boundary (e.g. 0.05 in our paper)." |
No description provided.
The text was updated successfully, but these errors were encountered: