New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TextualGradientDescentwithMomentum missing return statement #96

Open

jeffery1236 opened this issue Jul 29, 2024 · 1 comment

Labels

bug good first issue

jeffery1236 commented Jul 29, 2024

In the _update_prompt method of TextualGradientDescentwithMomentum, I found a missing return statement.

textgrad/textgrad/optimizer/optimizer.py

Line 233 in ee13ed7

def _update_prompt(self, variable: Variable, momentum_storage_idx: int):

mertyg added the good first issue label

Member

mertyg commented Aug 2, 2024

ah, great catch. we never used this after all, but we should fix this in the next release. thank you @jeffery1236 !

mertyg added the bug label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment