Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate line of code when computing _backward_idempotent #101

Open
linyuhongg opened this issue Aug 2, 2024 · 1 comment
Open

Duplicate line of code when computing _backward_idempotent #101

linyuhongg opened this issue Aug 2, 2024 · 1 comment

Comments

@linyuhongg
Copy link

In variable.py, the operation + calls _backward_idempotent for autograd, however, this function has a duplicate line of code line 349 and line 355 are the same code resulting in duplicate gradients for variables involved in the Function '+'.

@linyuhongg
Copy link
Author

Perhaps it was meant to work with _reduce_meta? However, it seems like if its not defined, it results in duplicate gradients when using +

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant