Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide notifications when clicking outside of them #241

Open
dstillman opened this issue Jun 12, 2018 · 5 comments
Open

Hide notifications when clicking outside of them #241

dstillman opened this issue Jun 12, 2018 · 5 comments
Assignees
Labels

Comments

@dstillman
Copy link
Member

I still don't think we've gotten notifications quite right. Having them auto-hide is sort of unsettling and not very accessible, but having to click the X or perform another action to close them is annoying. Rather than just closing them on another action, what about closing them on any click on the page outside?

@flachware
Copy link
Contributor

i think that’s worth a try.

@flachware
Copy link
Contributor

I just realized that we do not auto-hide the Item Deleted notifications anymore, do we do that on purpose for accessibility reasons?

@dstillman
Copy link
Member Author

do we do that on purpose for accessibility reasons?

Yes, that's right.

@flachware
Copy link
Contributor

Well in that case I’m all the more for trying the hide-on-any-click approach.

@tnajdek
Copy link
Member

tnajdek commented Aug 9, 2021

I've tried it and it doesn't feel right to me, I much prefer the way it works now i.e. explicit hide or significant action hides notifications. Are we sure we want to change it? Here is a branch where it clears on any click outside of a message: 241-click-anywhere-to-clear-messages

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

3 participants