Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Offer older connector version for Safari 9 #13

Open
dstillman opened this issue Oct 13, 2017 · 1 comment
Open

Offer older connector version for Safari 9 #13

dstillman opened this issue Oct 13, 2017 · 1 comment

Comments

@dstillman
Copy link
Member

We only test for the OS, but that means someone on 10.10 with Safari 9 will get the new connector, which won't work. We should test for the Safari version instead.
@dstillman
Copy link
Member Author

For the download script, I guess I'll just use this:

preg_match("/Version\/[5-9]\./", $_SERVER['HTTP_USER_AGENT'])

(Safari Extensions were introduced in Safari 5.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dstillman