Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSRF protection for oauth login links #51

Open
camallen opened this issue Jun 7, 2019 · 0 comments
Open

CSRF protection for oauth login links #51

camallen opened this issue Jun 7, 2019 · 0 comments
Assignees

Comments

@camallen
Copy link
Contributor

camallen commented Jun 7, 2019

When using oauth login links we have to be careful to avoid allowing activation of the oauth login process without ensuring the request originated by a known logged in user.

This is a recent exploit that was raised in rails land via omniauth/omniauth#809

A mitigation would be a CSRF validation via a POST method to the social auth routes before redirecting to the upstream social auth provider. Depending on what your application does with the upstream user data it may be a vector for account take over. I assume in this app it won't be, most likely changing the logged in user at worst but something to keep in mind with oauth flows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants