Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The encoding is not specified when opening the manifest file on Windows #79

Open
CKrawczyk opened this issue Jul 4, 2018 · 1 comment

Comments

@CKrawczyk
Copy link
Contributor

When working with the aggregation code I found out that on Windows the default encoding used for opening a file is not UTF-8, and caused issues with non-English characters in the file. It could be the cause of the issues seen here: https://www.zooniverse.org/talk/18/673942

Could be fixed by adding encoding='utf-8' to open function call on this line:

with open(manifest_file, 'U') as manifest_f:

@adammcmaster
Copy link
Contributor

The encoding option seems to have been added in Python 3, so I don't think we can do anything about this while we're will supporting Python 2.

When we do eventually fix this, we should probably add a command-line option to allow the user to specify the encoding rather than always forcing it to UTF-8 (but UTF-8 should probably be the default).

@adammcmaster adammcmaster changed the title The encoding is not specified when opening the manifest file The encoding is not specified when opening the manifest file on Windows Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants