Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Darien edit classroom view -- shared component reorganization? #85

Open
srallen opened this issue Nov 10, 2017 · 0 comments
Open

Darien edit classroom view -- shared component reorganization? #85

srallen opened this issue Nov 10, 2017 · 0 comments

Comments

@srallen
Copy link
Contributor

srallen commented Nov 10, 2017

Darien isn't going to want that same classroom edit page design as I2A because it's still hard coded for the I2A uses. I think I was overly ambitious with trying to make some of these components shared between the two. The programs have distinct view and routing needs, so I think we have a few options:

  • Darien gets its own edit classroom page design and we determine which to use similar to what I did in Darien classrooms table #74. I never really liked this solution
  • Or we completely separate the shared components into I2A components and Darien components. This would result in some repetition, but that's not necessarily a bad thing.
  • Or we separate the view components entirely and use HOC container components to inject in the class methods we want to share between the functional view components.
  • And/or abstract out shared API calls and methods into the appropriate ducks into async actions managed by jumpstate.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant