Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make unit tests truely locale independent #104

Open
matsduf opened this issue Apr 7, 2020 · 0 comments
Open

Make unit tests truely locale independent #104

matsduf opened this issue Apr 7, 2020 · 0 comments
Labels
S-PRforIssue Status: There is a PR that is meant to resolve the issue
Milestone
v2024.2

Comments

@matsduf
Copy link
Contributor

matsduf commented Apr 7, 2020

Issue #102 document a unit test that was locale dependent. That case was fixed with PR #103, but in a way that it is still not truely locale independent.

There are at least two options to make the unit tests truely locale independent:

  • Force the unit tests to run in locale C unless another locale is set on purpose.
  • Do not depend on error messages or anything that could be locale dependent.
@matsduf matsduf added this to the v2020.2 milestone Apr 7, 2020
@matsduf matsduf mentioned this issue Apr 7, 2020
Merged
@matsduf matsduf modified the milestones: v2020.2, v2021.2 Apr 14, 2021
@matsduf matsduf modified the milestones: v2021.2, v2022.1 Dec 8, 2021
@matsduf matsduf modified the milestones: v2022.1, v2022.2 May 21, 2022
@matsduf matsduf modified the milestones: v2022.2, v2023.1 Dec 20, 2022
@matsduf matsduf modified the milestones: v2023.1, v2023.2 Jun 26, 2023
@matsduf matsduf modified the milestones: v2023.2, v2024.1 Mar 19, 2024
@matsduf matsduf modified the milestones: v2024.1, v2024.2 Jul 3, 2024
@marc-vanderwal marc-vanderwal mentioned this issue Aug 29, 2024
Merged
@marc-vanderwal marc-vanderwal added the S-PRforIssue Status: There is a PR that is meant to resolve the issue label Sep 3, 2024
marc-vanderwal added a commit that referenced this issue Oct 11, 2024
@marc-vanderwal
Merge pull request #205 from marc-vanderwal/issue/#104
b65739d 
to_idn(): croak with locale-independent message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
S-PRforIssue Status: There is a PR that is meant to resolve the issue
Projects
None yet
Milestone
v2024.2
Development

No branches or pull requests
2 participants
@matsduf @marc-vanderwal