Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

History page discussion #447

Open
hannaeko opened this issue Nov 27, 2023 · 3 comments
Open

History page discussion #447

hannaeko opened this issue Nov 27, 2023 · 3 comments
Milestone

Comments

@hannaeko
Copy link
Member

hannaeko commented Nov 27, 2023

We have a few issues (and one PR) talking about the history.

So far the complaints are

I suggest we take the approach of having a "History" page, that the result page can link to. On this page we could have the list of previous tests, and when we click on one, we have the test result show below the list. This way we avoid the modal issue (screen reader user are informed that a new test result has been loaded using a live region), have a dedicated page to lookup a domain history, the result page and history page being two different page we avoid the refresh issue.

What do you think?

@matsduf
Copy link
Contributor

matsduf commented Nov 28, 2023

I think it sounds fine.

@tgreenx
Copy link
Contributor

tgreenx commented Nov 29, 2023

Same, sounds good to me.

I could see a heat map in such an History page, it is usually visually helpful.

@tgreenx tgreenx added this to the v2024.1 milestone Nov 29, 2023
@mattias-p
Copy link
Member

I agree. I like the idea of having a proper history page.

@matsduf matsduf modified the milestones: v2024.1, v2024.2 Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants