Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lint for CABF SMIME 7.1.2.3b - cRLDistributionPoints SHALL be present #742

Merged
merged 4 commits into from
Oct 8, 2023
Merged

Lint for CABF SMIME 7.1.2.3b - cRLDistributionPoints SHALL be present #742

merged 4 commits into from
Oct 8, 2023

Conversation

christopher-henderson
Copy link
Member

Resolves #741. Addresses SMIME certificates SHALL have cRLDistributionPoints (7.1.2.3.b) from #712

robplee
robplee reviewed Oct 5, 2023
View reviewed changes
v3/lints/cabf_smime_br/lint_subscribers_shall_have_crl_ddistribution_points.go Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"ddistribution" typo in filename

robplee
robplee reviewed Oct 5, 2023
View reviewed changes
v3/lints/cabf_smime_br/lint_subscribers_shall_have_crl_ddistribution_points_test.go Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same "ddistribution" typo here

robplee
robplee suggested changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@robplee robplee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easy to fix but there's a couple of typos in the filenames of the lint and it's tests.

@christopher-henderson christopher-henderson merged commit 386a8dc into master Oct 8, 2023
8 checks passed
@christopher-henderson christopher-henderson deleted the smime_crl_dist branch October 8, 2023 15:33
@christopher-henderson christopher-henderson mentioned this pull request Oct 15, 2023
Open
42 tasks
@jdkasten jdkasten mentioned this pull request Dec 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robplee robplee robplee requested changes

@zakird zakird zakird approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lint for CABF SMIME 7.1.2.3b - cRLDistributionPoints SHALL be present
3 participants
@christopher-henderson @zakird @robplee