Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thread panics on get_public_key() #45

Open
punkZK opened this issue Feb 17, 2022 · 1 comment
Open

Thread panics on get_public_key() #45

punkZK opened this issue Feb 17, 2022 · 1 comment

Comments

@punkZK
Copy link

punkZK commented Feb 17, 2022

I am experimenting with the zkSync Library and so started with some basic examples. It looks like get_public_key() can not handle manually created PK

import os
from zksync_sdk import ZkSyncLibrary

def main():
    library = ZkSyncLibrary()

    # I originally had a Metamask generated Private Key here as well
    # and it blew up too; so just creating a fake one here for the bug report.
    key1 = b"3" * 32
    pub_key = library.get_public_key(key1)


if __name__ == "__main__":
    main()

$ python test_zk.py
thread '' panicked at 'failed to get private key from bytes: NotInField("0x3333333333333333333333333333333333333333333333333333333333333333")', zks-crypto-c/src/utils.rs:144:53
note: run with RUST_BACKTRACE=1 environment variable to display a backtrace
fatal runtime error: failed to initiate panic, error 5
Abort trap: 6

@mutalisk999
Copy link

Same issue with u

    lib = ZkSyncLibrary(r"./zks_crypto.dll")
    key = bytes.fromhex("a"*64)
    signer = ZkSyncSigner(lib, key)
    print(signer.pubkey_hash().hex())
thread '<unnamed>' panicked at 'failed to get private key from bytes: NotInField("0xaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa")', zks-crypto-c\src\utils.rs:144:53
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
Traceback (most recent call last):
  File "D:\zkex-test\zkex-api-test.py", line 29, in <module>
    zk_account()
  File "D:\zkex-test\zkex-api-test.py", line 14, in zk_account
    signer = ZkSyncSigner(lib, key)
  File "C:\Python39\lib\site-packages\zksync_sdk\zksync_signer.py", line 24, in __init__
    self.public_key = self.library.get_public_key(self.private_key)
  File "C:\Python39\lib\site-packages\zksync_sdk\lib.py", line 66, in get_public_key
    self.lib.zks_crypto_private_key_to_public_key(pk, public_key)
OSError: exception: access violation reading 0x0000004369BF0000

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants