fix: fixes and simplifies autocomplete logic. #125
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takes zkemail#107 into consideration and fixes zkemail#123 i didnt wanna mess with SearchInput.tsx too much so i just modified the autocomplete function from actions.
|
This isn't correct, you just disabled our fix for #107. |
|
weird it works for me, did you test it? |
|
more testing: |
|
heres postgres documentation on this: and if you ever want more advanced maching you could use similarity threshold with https://www.postgresql.org/docs/current/pgtrgm.html but you have to install it first with prisma https://www.prisma.io/docs/orm/prisma-schema/postgresql-extensions#how-to-enable-the-postgresqlextensions-preview-feature:~:text=the%20hstore%2C-,pg_trgm,-and%20postgis%20extensions |
|
|
|
oh yeah for some reason i thought it was supposed to be like that, i was mostly thinking about the searchbar. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
takes #107 into consideration and fixes #123
i didnt wanna mess with SearchInput.tsx too much so i just modified the autocomplete function from actions.