Adding a Free Monad implementation but with a zio.prelude flare #1171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nused imports and variables
adamgfraser
reviewed
Jul 28, 2023
adamgfraser
reviewed
Jul 28, 2023
| * @tparam E - the error type if any | ||
| * @tparam A - the result type | ||
| */ | ||
| sealed trait ImperativeDsl[Dsl[+_, +_], +E, +A] { self => |
There was a problem hiding this comment.
I might call this Imperative just to make it a little shorter.
adamgfraser
reviewed
Jul 28, 2023
| onSuccess: A1 => Result[E2, A2], | ||
| onFailure: E1 => Result[E2, A2] | ||
| ): Result[E2, A2] = Result.suspend { | ||
| // TODO: Consider if this can be done with foldM since its pissible E1 or E2 is Nothing |
adamgfraser
reviewed
Jul 28, 2023
| } | ||
|
|
||
| // TODO: Consider what can be done to make the type lambda here simpler | ||
| implicit def ZPureToExecutable[W] |
There was a problem hiding this comment.
No point to the W parameter here unless you want to add other cases to Imperative. There is no way to interact with it.
adamgfraser
reviewed
Jul 28, 2023
| // TODO: Consider what can be done to make the type lambda here simpler | ||
| implicit def ZPureToExecutable[W] | ||
| : ToExecutable[({ type lambda[+E, +A] = ZPure[W, Unit, Unit, Any, E, A] })#lambda] = { | ||
| // ({ type lambda[+E, +A] = ZPure[W, Unit, Unit, Any, E, A] })#lambda |
adamgfraser
reviewed
Jul 28, 2023
| type InFailure <: E | ||
| } | ||
|
|
||
| // TODO: Consider what can be done to make the type lambda here simpler |
There was a problem hiding this comment.
Use EWriter or another appropriate ZPure type alias.
alphaho
reviewed
Aug 4, 2023
|
|
||
| /** | ||
| * An `Imperative[Dsl, E, A]` is a data structure that provides the ability to execute a user provided DSL as a sequence of operations. | ||
| * From a theoretical standpoint `ImperativeDsl` is an implementation of a Free Monad.`` |
There was a problem hiding this comment.
Suggested change
| * From a theoretical standpoint `ImperativeDsl` is an implementation of a Free Monad.`` | |
| * From a theoretical standpoint `Imperative` is an implementation of a Free Monad.`` |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a Free Monad structure under the name of
ImperativeDsl, as discussed with @jdegoes and in #1168