Support query parameters with multiple values in Endpoint API

[jdegoes]

Currently every query parameter is supposed to yield an A, but this should probably be changed to yield a NonEmptyChunk[A].

The main work is modifying Query which extends HttpCodec (inside the companion object of HttpCodec, located in file HttpCodec.scala) from extends HttpCodec[A] to extends HttpCodec[NonEmptyChunk[A]]. The secondary task is to modify the EncoderDecoder.scala so that it properly encodes and decodes non-empty chunks for query parameters.

[NavidJalali]

I can give this a go

[jdegoes]

/bounty $125

[algora-pbc]

💎 $125 bounty created by ZIO
🙋 If you start working on this, comment /attempt #2321 to notify everyone
👉 To claim this bounty, submit a pull request that includes the text /claim #2321 somewhere in its body
📝 Before proceeding, please make sure you can receive payouts in your country
💵 Payment arrives in your account 2-5 days after the bounty is rewarded
💯 You keep 100% of the bounty award
🙏 Thank you for contributing to zio/zio-http!

👉 Add a bounty • Share on socials

Attempt	Started (GMT+0)	Solution
🔴 @mpanigrahi	Aug 9, 2023, 4:29:43 AM	WIP
🟢 @eshu	Oct 7, 2023, 7:49:14 AM	WIP
🟢 @ekhov	Jan 15, 2024, 7:49:20 PM	#2631

[mpanigrahi]

/attempt #2321

Options

• Cancel my attempt

[mpanigrahi]

/attempt #2321

Options

• Cancel my attempt

[algora-pbc]

@mpanigrahi: Reminder that in 7 days the bounty will become up for grabs, so please submit a pull request before then 🙏

[algora-pbc]

The bounty is up for grabs! Everyone is welcome to /attempt #2321 🙌

[eshu]

Currently every query parameter is supposed to yield an A, but this should probably be changed to yield a NonEmptyChunk[A].

The main work is modifying Query which extends HttpCodec (inside the companion object of HttpCodec, located in file HttpCodec.scala) from extends HttpCodec[A] to extends HttpCodec[NonEmptyChunk[A]]. The secondary task is to modify the EncoderDecoder.scala so that it properly encodes and decodes non-empty chunks for query parameters.

@jdegoes

It does not look so simple. It does not look possible to make Query[A] just extends HttpCodec[NonEmptyChunk[A]], it breaks a lot of things inside, such as operator ++, Query.optional, I think there are many other things. So Query should stay as HttpCodec[A].

In other hand when I try to change just EncoderDecoder, it breaks Mechanic object in makeConstructorLoop method (coerce function).

Maybe there should be a special case Query or TextCodec.

Sorry, I saw this code just yesterday and I do not have a good understanding what is going on under the hood, most probably my thoughts are amateurish.

Update: I can't push the branch with changes, contributer's guide in README.md leads to 404 page (as well as Code of Conduct).

[eshu]

/attempt #2321

Options

• Cancel my attempt

[eshu]

@jdegoes
I have two solutions:
#2472 - I prefer this one
#2473 - I think ity could be acceptable, but I do not like it because of SeqCodec.encode.
Before I'll continue with tests I would like to know the opinion of maintainers which one is good.

[eshu]

@jdegoes Check the PR please :)
#2472

[eshu]

No need anymore?

[elisee-assinou]

i can work on this

[eshu]

@jdegoes This is not a question of money. I did not try to solve this issue for money.I do not think I can receive them because of the local specifics. I was inspired by your inspiring videos on youtube, read your messages in SN and thought that it is possible to do something for this project. But it looks like this project is in the stage "nobody cares". :(

[ekhov]

/attempt #2321

Options

• Cancel my attempt

[algora-pbc]

Note

The user @eshu is already attempting to complete issue #2321 and claim the bounty. We recommend checking in on @eshu's progress, and potentially collaborating, before starting a new solution.

[algora-pbc]

💡 @ekhov submitted a pull request that claims the bounty. You can visit your bounty board to reward.

[algora-pbc]

🎉🎈 @ekhov has been awarded $125! 🎈🎊

• Share on socials
• Give feedback