Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DefinitelyType ZingChart Angular - Properties are missing for Grid Chart. #33

Open
PITPL-Vivek-Pandya opened this issue Sep 30, 2022 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@PITPL-Vivek-Pandya
Copy link

1. style inside options > style - Missing properties are .th_first,.th_last, .td, .tr_odd, .th, .th_first

Screenshot from 2022-09-27 09-59-00
Screenshot from 2022-09-27 10-03-07
Screenshot from 2022-09-27 10-03-35
Screenshot from 2022-09-27 10-04-24
Screenshot from 2022-09-27 10-05-30

2. Also Please Check inner properties that's also should be missing.

image

@agois83 agois83 added the bug Something isn't working label Oct 28, 2022
@stuurman
Copy link

stuurman commented Dec 9, 2022

@zingsoftadmin
It is now December 9, the ticket was opened on September 30th.
2 years after filing a first bug #5, Angular typing is still not up to date.There are only improvements made, if someone files a bug and several reminders are made in the tickets. There does not seem any proactive work on producing correct typing.

Two questions arise:
Is Angular supported and is there a release date planned for fully correct typing?

@lasabahebwa
Copy link
Collaborator

lasabahebwa commented Dec 9, 2022

@stuurman Inside options > style - properties .th_first,.th_last, .td, .tr_odd, .th, .th_first for Grid chart were included. Did you try installing the latest version of @types/zingchart and zingchart-angular? This should resolve the issue. We're sorry we forgot to update the issue here.

@stuurman
Copy link

@lasabahebwa @zingsoftadmin
Thanks.

However, it is of no use for us to find out a chart is working after we give comments here, and after that include another chart, giving similar typing problems. It feels we are already almost 2 years alpha testing the typing support for ZingChart. We could like to import the typing and be sure we have type-safety. Is Zingchart's typing is now finally correct for all charts, and there will be no more need for file these kind of bugs?

@stuurman
Copy link

stuurman commented May 16, 2023

5 months later....

@zingsoftadmin
Is there any timeline that angular typings will be complete and correct for zing charts?
It is quite painful and error prone making our own shadow types, since problems keep popping up with the typings provided by zingchart. Please let the community know when there is a typing that works fully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

7 participants