Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Send All Results to Uptime Kuma Instance #9

Open
oumlala opened this issue Nov 22, 2024 · 7 comments
Open

Feature Request: Send All Results to Uptime Kuma Instance #9

oumlala opened this issue Nov 22, 2024 · 7 comments

Comments

@oumlala
Copy link
Contributor

oumlala commented Nov 22, 2024

Current Behavior

Currently, the Uptime Kuma remote probe only sends results to the Uptime Kuma instance when the HTTPS request returns an OK status.

Proposed Behavior

Modify the remote probe to send results to the Uptime Kuma instance for all HTTP status codes, not just OK responses.

Rationale

This change would provide more comprehensive monitoring data, allowing users to:

  • Track all types of responses
  • Identify intermittent issues more easily
  • Have a complete history of a monitored URL's performance

Implementation Suggestions

  1. Update the logic that determines when to send results
  2. Ensure all relevant data (status code, response time, etc.) is included in non-OK responses
  3. Consider adding a configuration option to allow users to choose between sending all results or only OK results

Additional Context

This feature would enhance the overall utility of the remote probe, providing users with more detailed insights into their monitored services.

@zimbres
Copy link
Owner

zimbres commented Nov 22, 2024

The push monitor tipo of UK dont allow such thing.

@oumlala
Copy link
Contributor Author

oumlala commented Nov 25, 2024

I've actually tested this functionality with Uptime Kuma's push monitor, and it does work with URL parameters. Specifically:

  • The 'status' parameter accepts values like "up" or "down"
  • The 'msg' parameter can be used to pass specific status messages

For example, when an HTTP check fails, I can successfully push:

  • status=down
  • msg=specific_error_message

As shown in the attached screenshot, this allows for more detailed monitoring information while maintaining compatibility with Uptime Kuma's push monitor functionality.

I'm willing to contribute and implement this feature if you agree.

Capture d’écran 2024-11-25 à 10 47 18

@zimbres
Copy link
Owner

zimbres commented Dec 5, 2024

I see, but I prefer to keep it simple.

There are already lots of tools to perform more granular monitoring,

@oumlala
Copy link
Contributor Author

oumlala commented Dec 6, 2024

I understand your preference for simplicity, and I respect that approach. However, I'd like to highlight a few points about this feature:

  1. It's completely optional and disabled by default, so it won't affect existing users or add complexity to the base functionality
  2. It requires zero additional configuration on Uptime Kuma's side since it uses the existing push monitor URL parameters
  3. It adds value for users who need more detailed monitoring without requiring them to set up additional tools
  4. The implementation is very lightweight and doesn't introduce any new dependencies

If this feature isn't accepted, I'll need to maintain a separate fork, which would prevent me from contributing to the main project in the future. I believe it would be more beneficial for the community to keep the codebase unified rather than fragmented.

The goal is to enhance the existing functionality while maintaining the tool's simplicity. Users who prefer the basic functionality can continue using it as is, while others can benefit from more detailed status information when needed.

Would you be open to reconsider with these points in mind?

@zimbres
Copy link
Owner

zimbres commented Dec 6, 2024

I understand but I will keep it simple.

I work with monitoring needs in my daily tasks and UK is the wrong tool to do this kind of monitor. In fact UK is already bloated in features since its main purpose was to be an option to UptimeRobot, also this probe is already bloated.

@oumlala
Copy link
Contributor Author

oumlala commented Dec 9, 2024

I respect your perspective and commitment to keeping Uptime Kuma focused on its core purpose. Since you work with monitoring needs daily, could you recommend an open-source monitoring tool that would be more suitable for this kind of detailed monitoring, while still maintaining a push-based architecture with remote probes sending data to a central instance ?

@zimbres
Copy link
Owner

zimbres commented Dec 9, 2024

In this case, I use Prometheus and Grafana with blackbox exporter to query the monitored website/api.

Zabbix might be an good option as well, but the first option is more modern way with cloud native approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants