Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken identifier highlighting #26

Open
souporserious opened this issue Mar 5, 2023 · 2 comments
Open

Broken identifier highlighting #26

souporserious opened this issue Mar 5, 2023 · 2 comments

Comments

@souporserious
Copy link

souporserious commented Mar 5, 2023

First, thank you so much for the work on this project! I haven't been able to get any other solutions working for TextMate grammars besides this library.

I'm running into a weird issue that I was able to trace to the 0.30.0 of monaco-editor. Moving between both of the versions will produce the following inconsistencies when highlighting identifiers in certain cases:

Before 0.29.1

image

After 0.30.0

image

I'm not entirely sure how all of the highlighting is working and wish I could provide more information. It's not clear either why things started breaking between those two versions as the changes seem unrelated.

This repo showcases the issue in a previous commit here. I've fixed the version (managed by @monaco-editor/loader) to get around the issue for now.

@zikaari
Copy link
Owner

zikaari commented Mar 7, 2023

Hi Travis, I wish I could help you, but I have been out of touch with this library (and other sibling libraries that I have) for 4 years now. I'm happy to approve any pull request and re-publish it on NPM if you're willing to take this on. Cheers.

@souporserious
Copy link
Author

No worries, totally understand. I appreciate the response! I've been actively trying to find a solution and will post a PR if I can come up with anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants