Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wildcard include does not work in windows #183

Closed
Kilerd opened this issue Oct 8, 2023 · 1 comment · Fixed by #187
Closed

wildcard include does not work in windows #183

Kilerd opened this issue Oct 8, 2023 · 1 comment · Fixed by #187
Labels
Backend bug Something isn't working windows

Comments

@Kilerd
Copy link
Collaborator

Kilerd commented Oct 8, 2023

[core\src\transform.rs:47] main_endpoint.as_path().to_str().unwrap() = "\\\\?\\C:\\Users\\kilerd\\projects\\zhang\\examples\\example.zhang"

seems like we canonicalize the path into string for parsing it as glob pattern, and it escape chars, so it does not work

@Kilerd Kilerd added bug Something isn't working Backend windows labels Oct 8, 2023
@Kilerd
Copy link
Collaborator Author

Kilerd commented Oct 8, 2023

better we can determinate whether the path is glob pattern or not.
if it is not a pattern, we access it directly.

rust-lang/glob#72

@Kilerd Kilerd linked a pull request Nov 2, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backend bug Something isn't working windows
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant