Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the contracts upgradeable #5

Closed
fadeev opened this issue Nov 30, 2024 · 3 comments · Fixed by #6
Closed

Make the contracts upgradeable #5

fadeev opened this issue Nov 30, 2024 · 3 comments · Fixed by #6

Comments

@fadeev
Copy link
Member

fadeev commented Nov 30, 2024

Remove constructor, use initialize, instead.

@fadeev
Copy link
Member Author

fadeev commented Nov 30, 2024

Add this to initialize:

I'm now thinking that with universal NFT/FT we can streamline the deploy process by adding universal contract address as one of the constructor parameters with deploying a connected contract. The idea is you should always deploy the universal contract first, because it's a single required component, and then deploy connected contracts. This way connected-set-universal task will no longer be required. It still makes sense to keep it as contract addresses may change, but you wouldn't need to set manually it after deploying a connected contract.

@fadeev fadeev linked a pull request Dec 4, 2024 that will close this issue
@lukema95
Copy link

@fadeev What other repos contracts need to be upgraded? Maybe I can take some.

@fadeev
Copy link
Member Author

fadeev commented Dec 20, 2024

@lukema95 the PR above already takes care of this.

If you're looking for issues to contribute to, I recommend checking out zeta-chain/universalkit#30 and zeta-chain/localnet#54

@fadeev fadeev closed this as completed in #6 Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants