Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potentially missed observation from Polygon #3308

Open
fadeev opened this issue Dec 17, 2024 · 5 comments
Open

Potentially missed observation from Polygon #3308

fadeev opened this issue Dec 17, 2024 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@fadeev
Copy link
Member

fadeev commented Dec 17, 2024

https://polygonscan.com/tx/0x06a0ec87f5c6dab11eed5da1357035590d7d54559679c4b1dc3d07264cb51b30

@lumtis lumtis added the bug Something isn't working label Dec 17, 2024
@lumtis
Copy link
Member

lumtis commented Dec 17, 2024

Found the tx, the validation can't be processed https://zetachain.explorers.guru/transaction/764A5A9207CC844EC3A26300C3FB8C7B35E58E194EF25E5CD8C03FB68E6E9614

On the condition that produces the error is that it seems we're doing a BTC withdraw in the crosschain call that doesn't work because it is less than theBTC dust amount.

On the error itself, it seems that under this workflow, the observation tx fails at the Cosmos level, failing the whole txs making the processing of the inbound impossible

@nzmpi
Copy link

nzmpi commented Dec 18, 2024

@lumtis That's my tx. Thank you for your answer!
Does this mean that if I am trying to send less BTC than dust amount (1000?) a transaction will revert, and without calling OnRevert on the original EVM chain? So those funds are just lost?

@lumtis
Copy link
Member

lumtis commented Dec 18, 2024

No, it is not lost, it is blocked until there is a fix applied.
Did you make other deposits that didn't get observed?

@nzmpi
Copy link

nzmpi commented Dec 18, 2024

Did you make other deposits that didn't get observed?

Not yet, do I need to update my contract on Zetachain to prevent this in future? Like reverting if a user tries to send too little BTC?

@lumtis
Copy link
Member

lumtis commented Dec 18, 2024

We need to upgrade the protocol to fix the workflow and make the CCTX revert, once implemented this currently blocked CCTX will get observed and reverted.
But before upgrade, yes, you can add a check in the smart contract. The Bitcoin dust amount is 1000sat, if you add a require(withdrawAmount > 1000) then the CCTX should be reverted. This check will be no longer necessary after Bitcoin upgrade.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants