Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MsgEthereumTx emits wrong coin received log entries in cosmos event logs #2836

Closed
brewmaster012 opened this issue Sep 6, 2024 · 0 comments · Fixed by #2854
Closed

MsgEthereumTx emits wrong coin received log entries in cosmos event logs #2836

brewmaster012 opened this issue Sep 6, 2024 · 0 comments · Fixed by #2854
Assignees
Labels
bug Something isn't working

Comments

@brewmaster012
Copy link
Collaborator

brewmaster012 commented Sep 6, 2024

Describe the Bug
it looks to me the ethereum tx cosmos logs are buggy.
According to the logs, net balances change would be
zeta1nlflyqcp5qfty97e8ppgndjhn2z7a094q9mgty +0.4zeta
zeta1futgfg5wx06zeh6s4wtw9xnsnctjf8nrcvu9sr -0.4zeta
while in fact ethereum tx receipt shows 0.2 zeta is transfered.
The actual balance change agrees with the ethereum tx receipt but not the cosmos logs.

%  curl -H "X-Cosmos-Block-Height: 4715531" "[https://zetachain.blockpi.network:443/lcd/v1/public/cosmos/bank/v1beta1/balances/zeta1nlflyqcp5qfty97e8ppgndjhn2z7a094q9mgty](https://zetachain.blockpi.network/lcd/v1/public/cosmos/bank/v1beta1/balances/zeta1nlflyqcp5qfty97e8ppgndjhn2z7a094q9mgty)"
{"balances":[{"denom":"azeta","amount":"95044500000000000"}],"pagination":{"next_key":null,"total":"1"}}
%  curl -H "X-Cosmos-Block-Height: 4715532" "[https://zetachain.blockpi.network:443/lcd/v1/public/cosmos/bank/v1beta1/balances/zeta1nlflyqcp5qfty97e8ppgndjhn2z7a094q9mgty](https://zetachain.blockpi.network/lcd/v1/public/cosmos/bank/v1beta1/balances/zeta1nlflyqcp5qfty97e8ppgndjhn2z7a094q9mgty)"
{"balances":[{"denom":"azeta","amount":"295044500000000000"}],"pagination":{"next_key":null,"total":"1"}}

Looks like the ethermint module MsgEthereumTx hanlder emits duplicate logs, but it did not actually sent duplicate coins.

To Reproduce
Use metamask to send some zeta to another address. Look at the cosmos logs in the tx.

Expected Behavior
The cosmos logs coin received should be the same as actual balance change.

Screenshots
If applicable, add screenshots to help explain your problem.

Environment (please complete the following information):
N/A

@brewmaster012 brewmaster012 added the bug Something isn't working label Sep 6, 2024
@CharlieMc0 CharlieMc0 added this to the September Release (v21) milestone Sep 6, 2024
@skosito skosito mentioned this issue Sep 9, 2024
5 tasks
@skosito skosito linked a pull request Sep 9, 2024 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants