From e533f7eff443412b237428b3096d7ae3bfae530b Mon Sep 17 00:00:00 2001 From: Tanmay Date: Fri, 20 Dec 2024 13:30:12 -0500 Subject: [PATCH] fixed test naming --- x/observer/migrations/v9/migrate.go | 1 - x/observer/migrations/v9/migrate_test.go | 4 ++-- x/observer/types/ballot_test.go | 4 ++-- 3 files changed, 4 insertions(+), 5 deletions(-) diff --git a/x/observer/migrations/v9/migrate.go b/x/observer/migrations/v9/migrate.go index 14c6dc7af6..ba19b665e7 100644 --- a/x/observer/migrations/v9/migrate.go +++ b/x/observer/migrations/v9/migrate.go @@ -19,7 +19,6 @@ const MaturityBlocks = int64(100) func MigrateStore(ctx sdk.Context, observerKeeper observerKeeper) error { currentHeight := ctx.BlockHeight() // Maturity blocks is a parameter in the emissions module - if currentHeight < MaturityBlocks { return nil } diff --git a/x/observer/migrations/v9/migrate_test.go b/x/observer/migrations/v9/migrate_test.go index b13012613f..e584bb9dc9 100644 --- a/x/observer/migrations/v9/migrate_test.go +++ b/x/observer/migrations/v9/migrate_test.go @@ -72,7 +72,7 @@ func TestMigrateStore(t *testing.T) { } }) - t.Run("do not thing if ballot list for height is not found", func(t *testing.T) { + t.Run("do nothing if ballot list for height is not found", func(t *testing.T) { //Arrange k, ctx, _, _ := keepertest.ObserverKeeper(t) // Set current height to 1000 @@ -108,7 +108,7 @@ func TestMigrateStore(t *testing.T) { require.Equal(t, numberOfActualBlocks*numberOfBallotsPerBlock, int64(len(allBallotsAfterMigration))) }) - t.Run("do not thing if current height is less than maturity blocks", func(t *testing.T) { + t.Run("do nothing if current height is less than maturity blocks", func(t *testing.T) { //Arrange k, ctx, _, _ := keepertest.ObserverKeeper(t) // Set current height to 100 diff --git a/x/observer/types/ballot_test.go b/x/observer/types/ballot_test.go index 7127074605..c902a9aaac 100644 --- a/x/observer/types/ballot_test.go +++ b/x/observer/types/ballot_test.go @@ -488,7 +488,7 @@ func TestBallot_GenerateVoterList(t *testing.T) { err require.ErrorAssertionFunc }{ { - name: "Success observation", + name: "success observation", voters: []string{"Observer1", "Observer2", "Observer3", "Observer4"}, votes: []VoteType{ VoteType_SuccessObservation, @@ -518,7 +518,7 @@ func TestBallot_GenerateVoterList(t *testing.T) { }, { - name: "Failure observation", + name: "failure observation", voters: []string{"Observer1", "Observer2", "Observer3", "Observer4"}, votes: []VoteType{ VoteType_FailureObservation,