Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selftests had to run sequentially #297

Open
jimklimov opened this issue Dec 16, 2017 · 2 comments
Open

Selftests had to run sequentially #297

jimklimov opened this issue Dec 16, 2017 · 2 comments

Comments

@jimklimov
Copy link
Member

When preparing Jenkinsfile integration, some tests failed if several runs in the same operating environment happened simultaneously. Job had to be marked sequential=1.

Revise if this is still valid, fix whatever is offending (if still valid).

Probable offenders can include hardcoded fixed port numbers, file names (including unix domain sockets, IPC, etc.) or agent names on the stream - so several processes might collide, steal each others responses, etc. unexpectedly for current selftest code.

@bluca
Copy link
Member

bluca commented Dec 16, 2017

I thought we fixed them all? There were no IPC and all TCP bind are dynamic now iirc

@jimklimov
Copy link
Member Author

jimklimov commented Dec 16, 2017

I did not have time to dig deeper into the why's - just noticed that empirically tests done in parallel tended to fail recently. At least, a reminder to myself to retest if this is still a real issue; if not, can make tests parallel again :\ Either way, actionable issue ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants