Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shouldn't assume there's a body for error 4xx #13

Open
dlq84 opened this issue Oct 5, 2016 · 1 comment
Open

Shouldn't assume there's a body for error 4xx #13

dlq84 opened this issue Oct 5, 2016 · 1 comment
Assignees
Milestone

Comments

@dlq84
Copy link

dlq84 commented Oct 5, 2016

I think this library is too strict and should not assume there's a body in case of error 4xx. the rfc says SHOULD contain a body, and not MUST. Which by the definition of SHOULD in rfc2119 means it's only recommended.

Thoughts?

10.4 Client Error 4xx

"the server SHOULD include an entity containing an explanation of the error situation, and whether it is a temporary or permanent condition. These status codes are applicable to any request method. User agents SHOULD display any included entity to the user."

https://www.w3.org/Protocols/rfc2616/rfc2616-sec10.html

@dlq84 dlq84 changed the title Shouldn't assume there's a body Shouldn't assume there's a body for error 4xx Oct 5, 2016
@philippspinnler philippspinnler self-assigned this Oct 28, 2016
@philippspinnler philippspinnler added this to the 1.4.0 milestone Oct 28, 2016
@philippspinnler
Copy link
Member

You are absolutely right. I designed this library for a specific project in which there always was a body set in case of a 4xx error. I'm going to change it in 1.4.0 release or just feel free to create a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants