-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
poweroff: nordic: streamline RAM retention strategy #82262
Open
nika-nordic
wants to merge
4
commits into
zephyrproject-rtos:main
Choose a base branch
from
nika-nordic:add_nrf_ram_retention_zephyrupstream
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
poweroff: nordic: streamline RAM retention strategy #82262
nika-nordic
wants to merge
4
commits into
zephyrproject-rtos:main
from
nika-nordic:add_nrf_ram_retention_zephyrupstream
+160
−187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Common symbol is defined by SoCs that support RAM control helper. Signed-off-by: Nikodem Kastelik <[email protected]>
Updated retained_mem driver variant exposes vendor-specific API, rather than executing implicitly during boot. Signed-off-by: Nikodem Kastelik <[email protected]>
nika-nordic
requested review from
kl-cruz,
anangl,
gmarull,
masz-nordic,
bjarki-andreasen and
nordic-piks
November 28, 2024 14:18
zephyrbot
added
area: Retained Memory
area: Samples
Samples
platform: nRF
Nordic nRFx
labels
Nov 28, 2024
zephyrbot
requested review from
hubertmis,
jaz1-nordic,
kartben,
krish2718,
magp-nordic,
nashif,
nordic-krch,
nordicjm and
sachinthegreen
November 28, 2024 14:19
nika-nordic
removed request for
kartben,
nashif,
krish2718,
sachinthegreen,
magp-nordic and
jaz1-nordic
November 28, 2024 14:20
nika-nordic
force-pushed
the
add_nrf_ram_retention_zephyrupstream
branch
from
November 28, 2024 14:25
5dce89b
to
d7eec5f
Compare
zephyrbot
requested review from
krish2718,
magp-nordic,
nashif and
sachinthegreen
November 28, 2024 14:26
bjarki-andreasen
previously approved these changes
Nov 28, 2024
nordicjm
previously approved these changes
Nov 29, 2024
Adding |
RAM retention is disabled for all RAM blocks before entering System OFF to achieve lowest power consumption. RAM retention can still be enabled using retained_mem driver. Signed-off-by: Nikodem Kastelik <[email protected]>
Using bare-metal approach for retention configuration is no longer compatible with sys_poweroff() implementation. Signed-off-by: Nikodem Kastelik <[email protected]>
nika-nordic
dismissed stale reviews from nordicjm and bjarki-andreasen
via
November 29, 2024 16:01
80a7fe7
nika-nordic
force-pushed
the
add_nrf_ram_retention_zephyrupstream
branch
from
November 29, 2024 16:01
d7eec5f
to
80a7fe7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: Retained Memory
area: Samples
Samples
DNM
This PR should not be merged (Do Not Merge)
platform: nRF
Nordic nRFx
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
retained_mem should be used for RAM retention management on nRF devices.
sys_poweroff
should disable RAM retention for unused RAM blocks to achieve lowest power consumption in System OFF state.Align
system_off
sample accordingly.