runners: jlink: Fix NoneType object error #79889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commit 221199e presents a bug that makes west flash failed with error. AttributeError: 'NoneType' object has no attribute 'startswith' In function is_tunnel(), tunnel may contain None and has no attribute "startswith". Fix it. Signed-off-by: Phi Bang Nguyen <[email protected]>
zephyrbot
added
size: XS
zephyrbot
requested review from
carlescufi,
mbolivar-ampere,
pdgendt and
swinslow
|
attn: @adamdunkels |
pdgendt
approved these changes
Oct 15, 2024
looks good! |
|
CI error seems unrelated to the change:
|
kartben
approved these changes
Oct 16, 2024
dleach02
added
the
Trivial
dleach02
approved these changes
Oct 16, 2024
Global CI issue, new PRs has this CI error now. |
Has been fixed in #79904, rebase on main |
dleach02
added
the
Hotfix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit 221199e presents a bug that makes west flash failed with error.
AttributeError: 'NoneType' object has no attribute 'startswith'
In function is_tunnel(), tunnel may contain None and has no attribute "startswith".