thrift: Define module-wide _POSIX_C_SOURCE feature test macro #79873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfriedt
previously approved these changes
Oct 15, 2024
cfriedt
reviewed
Oct 15, 2024
stephanosio
force-pushed
the
thrift_ctime_r
branch
from
0e138b6 to
a97c4a5
Compare
cfriedt
previously approved these changes
Oct 16, 2024
kartben
previously approved these changes
Oct 16, 2024
ycsin
previously approved these changes
Oct 16, 2024
stephanosio
force-pushed
the
thrift_ctime_r
branch
from
a97c4a5 to
e7cc582
Compare
|
Rebased |
|
Please rebase on |
The Thrift module tests were under the "newlib" namespace, presumably because newlib was the default at the time of their introduction. Since newlib is no longer the default libc and Thrift is not being tested against multiple C libraries, this removes the libc type from the Thrift test identifiers. Signed-off-by: Stephanos Ioannidis <[email protected]>
The Thrift library makes use of POSIX C functions such as ctime_r(), which are not part of the ISO C standard. This commit adds a Thrift module-wide `_POSIX_C_SOURCE` feature test macro definition in order to ensure that the required POSIX C functions are available when compiling the Thrift library. Note that this was not caught earlier because Newlib and older versions of Picolibc did not properly fence off some POSIX functions behind the feature test macros. Signed-off-by: Stephanos Ioannidis <[email protected]>
stephanosio
dismissed stale reviews from ycsin, cfriedt, and kartben
via
7351e1f
stephanosio
force-pushed
the
thrift_ctime_r
branch
from
e7cc582 to
7351e1f
Compare
|
Rebased |
ycsin
approved these changes
Oct 22, 2024
cfriedt
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Thrift library makes use of POSIX C functions such as ctime_r(), which
are not part of the ISO C standard.
This commit adds a Thrift module-wide
_POSIX_C_SOURCEfeature test macrodefinition in order to ensure that the required POSIX C functions are
available when compiling the Thrift library.
Note that this was not caught earlier because Newlib and older versions of
Picolibc did not properly fence off some POSIX functions behind the feature
test macros.