Support SDHC driver for Renesas RA8 devices #79862

khoa-nguyen-18 · 2024-10-15T11:50:16Z

Add support for SDHC driver running on Renesas RA8

boards: renesas: Add support for sdhc
drivers: disk: Add support for sdhc driver
dts: renesas: Add support for SDHC node.
dts: bindings: Add support for sdhc driver.
tests: drivers: disk: disk_performance: Add support for RA8.
tests: drivers: disk: disk_access: Add support for RA8.

zephyrbot · 2024-10-15T11:51:10Z

The following west manifest projects have changed revision in this Pull Request:

Name	Old Revision	New Revision	Diff

✅ All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

danieldegrasse

Thank you for the contribution, but this driver is implementing the disk API directly for an SD host controller. New SD host controllers need to be implemented using the SDHC API: https://docs.zephyrproject.org/latest/hardware/peripherals/sdhc.html.

Take a look at the drivers within drivers/sdhc for some examples of how this would be implemented.

khoa-nguyen-18 · 2024-10-17T11:27:10Z

Thank you for the contribution, but this driver is implementing the disk API directly for an SD host controller. New SD host controllers need to be implemented using the SDHC API: https://docs.zephyrproject.org/latest/hardware/peripherals/sdhc.html.

Take a look at the drivers within drivers/sdhc for some examples of how this would be implemented.

We noticed a similar implementation for the disk driver on the SDMMC IP in drivers\disk\sdmmc_stm32.c. If we want to support SDMMC, do we have to implement it in drivers/sdhc, instead of drivers/disk?

danieldegrasse · 2024-10-17T13:37:32Z

We noticed a similar implementation for the disk driver on the SDMMC IP in drivers\disk\sdmmc_stm32.c. If we want to support SDMMC, do we have to implement it in drivers/sdhc, instead of drivers/disk?

Yes, you do- I'm sorry that the STM32 implementation made things unclear. This implementation is present from before the SDHC layer was introduced, and needs to be transitioned to use the SDHC class instead of the disk driver layer. New implementations should not be based off it

drivers/sdhc/sdhc_renesas_ra.c

dts/arm/renesas/ra/ra8/ra8x1.dtsi

samples/subsys/fs/fs_sample/boards/ek_ra8d1.overlay

drivers/sdhc/sdhc_renesas_ra.c

quytranpzz · 2024-11-25T06:58:08Z

Rebases to update HAL commit ID

drivers/sdhc/sdhc_renesas_ra.c

quytranpzz · 2024-12-03T06:19:05Z

@danieldegrasse : Could you please revisit this PR? Thank you

drivers/sdhc/sdhc_renesas_ra.c

danieldegrasse

Thanks for all your work here!

duynguyenxa · 2024-12-05T07:42:30Z

boards/renesas/ek_ra8d1/ek_ra8d1-pinctrl.dtsi

+			<RA_PSEL(RA_PSEL_SDHI, 4, 3)>,
+			<RA_PSEL(RA_PSEL_SDHI, 4, 4)>,
+			<RA_PSEL(RA_PSEL_SDHI, 4, 5)>,
+			<RA_PSEL(RA_PSEL_SDHI, 7, 0)>;


@quytranpzz This pin is conflicting with the spi0_default node

duynguyenxa · 2024-12-05T07:48:12Z

boards/renesas/ek_ra8d1/ek_ra8d1.dts

+&sdhc1 {
+	compatible = "renesas,ra-sdhc";
+	interrupt-names = "accs", "card", "dma-req";
+	interrupts = <60 12>, <61 12>, <62 12>;
+	pinctrl-0 = <&sdhc1_default>;
+	pinctrl-names = "default";
+	status = "okay";
+	sdmmc {
+		compatible = "zephyr,sdmmc-disk";
+		disk-name = "SD";
+		status = "okay";
+	};
+};


@thaoluonguw , @KhiemNguyenT , @soburi , the EK_RA8M1 and EK_RA8D1 doesn't support SD slot default on board but require external board, should we set its status as "okay" in board.dts?

I moved the sdhc support with the status "okay" into app overlay for EK_RA8M1 and EK_RA8D1 because it requires external hardware and avoids some pins conflicts as above, keeps only for MCK-RA8T1
@KhiemNguyenT @thaoluonguw @soburi @duynguyenxa: please take a look. Thank you

@danieldegrasse : sorry for inconvenience but could you please take another look? The driver implementation is unchanged, but the DTS support for the EK-RA8D1 and EK-RA8M1 boards has been updated as above discussed. Thank you

So if I understand right, an external board is required for support here, which contains an SD card slot? A few questions:

Is this external board standardized between multiple EVKs? That is, can it be reused on multiple Renesas EVKs?

Is this board a product that can be purchased, or a custom rework to connect an SD card?

If the board is a product that can be purchased and is reusable across multiple boards, then I would suggest defining the board as a shield, so that it can be reused across multiple Renesas EVKs. You'll need to define a standard node name for the SDHC controller that exposes the pins the shield connects to- maybe something like renesas_ext_sdhc? See here for an example of this with NXP EVKs for an LCD interface:

zephyr/boards/shields/lcd_par_s035/lcd_par_s035_8080.overlay

Line 33 in 2d60d24

&zephyr_mipi_dbi_parallel {

thaoluonguw · 2024-12-05T07:15:25Z

boards/renesas/ek_ra8m1/ek_ra8m1.yaml

@@ -10,3 +10,4 @@ toolchain:
 supported:
  - gpio
  - uart
+  - sdhc


@quytranpzz : Is it necessary to support as default?

thaoluonguw · 2024-12-05T07:19:23Z

drivers/sdhc/Kconfig.renesas_ra

+	select USE_RA_FSP_DTC
+	select PINCTRL
+	help
+	  Enables Renesas Host controller driver


Should it be "Enable Renesas SD Host controller driver"?

Yes, I updated it.

thaoluonguw · 2024-12-05T07:20:29Z

drivers/sdhc/sdhc_renesas_ra.c

+#include <zephyr/drivers/pinctrl.h>
+#include <zephyr/drivers/gpio.h>
+#include <zephyr/irq.h>
+#include <soc.h>
+#include <zephyr/drivers/pinctrl.h>


Duplicated include <zephyr/drivers/pinctrl.h>

I removed it, thanks

This is initial commit to support SDHC driver on Renesas RA8 with r_sdhi modules Signed-off-by: Tran Van Quy <[email protected]>

Add node on RA8 dts to support sdhc as channel 0 and channel 1 Signed-off-by: Tran Van Quy <[email protected]>

Add board support for SDHC driver on EK-RA8M1, EK-RA8D1 and MCK-RA8T1 Signed-off-by: Tran Van Quy <[email protected]>

Add sdhc property in tests/disk to support SDHC on RA8 boards Signed-off-by: Tran Van Quy <[email protected]>

Add overlay property node to support samples/fs/fs_sample on RA8 boards Signed-off-by: Quy Tran <[email protected]>

Add overlay property node and configs to support tests/subsys/fs/ext2, tests/fs/fat_fs_api and tests/subsys/sd on RA8 boards Signed-off-by: Quy Tran <[email protected]>

zephyrbot added manifest manifest-hal_renesas DNM This PR should not be merged (Do Not Merge) labels Oct 15, 2024

thaoluonguw marked this pull request as ready for review October 15, 2024 12:19

thaoluonguw added the platform: Renesas RA Renesas Electronics Corporation, RA label Oct 15, 2024

zephyrbot added the area: Disk Access label Oct 15, 2024

zephyrbot requested review from danieldegrasse, decsny, duynguyenxa, jfischer-no, KhiemNguyenT, soburi and thaoluonguw October 15, 2024 12:19

zephyrbot assigned danieldegrasse Oct 15, 2024

danieldegrasse requested changes Oct 15, 2024

View reviewed changes

khoa-nguyen-18 force-pushed the support_renesas_ra8_sdmmc branch 2 times, most recently from c1bba4d to d3fed74 Compare October 16, 2024 06:26

quytranpzz force-pushed the support_renesas_ra8_sdmmc branch from d3fed74 to 1280afe Compare November 13, 2024 02:55

zephyrbot added area: File System area: Samples Samples labels Nov 13, 2024

zephyrbot requested review from de-nordic, kartben, Laczen and nashif November 13, 2024 02:56

khoa-nguyen-18 changed the title ~~Support SDMMC driver for Renesas RA8 devices~~ Support SDHC driver for Renesas RA8 devices Nov 13, 2024

quytranpzz force-pushed the support_renesas_ra8_sdmmc branch 2 times, most recently from d7b2ce3 to 6ca7c1e Compare November 13, 2024 03:14

danieldegrasse reviewed Nov 20, 2024

View reviewed changes

quytranpzz force-pushed the support_renesas_ra8_sdmmc branch from 90c0f54 to 36d04d7 Compare November 22, 2024 10:50

danieldegrasse reviewed Nov 22, 2024

View reviewed changes

drivers/sdhc/sdhc_renesas_ra.c Show resolved Hide resolved

quytranpzz force-pushed the support_renesas_ra8_sdmmc branch 2 times, most recently from 5937771 to bcdb3a1 Compare November 25, 2024 06:55

zephyrbot removed the DNM This PR should not be merged (Do Not Merge) label Nov 25, 2024

danieldegrasse reviewed Nov 25, 2024

View reviewed changes

drivers/sdhc/sdhc_renesas_ra.c Show resolved Hide resolved

pdgendt reviewed Dec 3, 2024

View reviewed changes

drivers/sdhc/sdhc_renesas_ra.c Outdated Show resolved Hide resolved

quytranpzz force-pushed the support_renesas_ra8_sdmmc branch from bcdb3a1 to 8b4e25b Compare December 3, 2024 09:57

zephyrbot added the DNM This PR should not be merged (Do Not Merge) label Dec 3, 2024

quytranpzz force-pushed the support_renesas_ra8_sdmmc branch from 8b4e25b to 5d0f524 Compare December 3, 2024 10:02

zephyrbot removed the DNM This PR should not be merged (Do Not Merge) label Dec 3, 2024

pdgendt reviewed Dec 3, 2024

View reviewed changes

drivers/sdhc/sdhc_renesas_ra.c Outdated Show resolved Hide resolved

quytranpzz force-pushed the support_renesas_ra8_sdmmc branch from 5d0f524 to ba362f9 Compare December 3, 2024 10:22

danieldegrasse previously approved these changes Dec 3, 2024

View reviewed changes

duynguyenxa reviewed Dec 5, 2024

View reviewed changes

thaoluonguw reviewed Dec 5, 2024

View reviewed changes

quytranpzz added 2 commits December 10, 2024 10:32

drivers: sdhc: support SDHC driver on Renesas RA8

cf13364

This is initial commit to support SDHC driver on Renesas RA8 with r_sdhi modules Signed-off-by: Tran Van Quy <[email protected]>

dts: renesas: add dts entry node to support sdhc on Renesas RA8

9a7fb97

Add node on RA8 dts to support sdhc as channel 0 and channel 1 Signed-off-by: Tran Van Quy <[email protected]>

quytranpzz dismissed danieldegrasse’s stale review via 968b50d December 10, 2024 03:41

quytranpzz force-pushed the support_renesas_ra8_sdmmc branch from ba362f9 to 968b50d Compare December 10, 2024 03:41

zephyrbot removed manifest manifest-hal_renesas labels Dec 10, 2024

quytranpzz added 4 commits December 10, 2024 14:53

boards: renesas: Add board support for SDHC driver

1224296

Add board support for SDHC driver on EK-RA8M1, EK-RA8D1 and MCK-RA8T1 Signed-off-by: Tran Van Quy <[email protected]>

tests: disk: Add overlay to support sdhc on RA8

f3c2363

Add sdhc property in tests/disk to support SDHC on RA8 boards Signed-off-by: Tran Van Quy <[email protected]>

samples: fs: Support samples fs on RA8 boards

7c1f614

Add overlay property node to support samples/fs/fs_sample on RA8 boards Signed-off-by: Quy Tran <[email protected]>

tests: subsys: fs: Support tests/subsys/fs on RA8 boards

dc724ce

Add overlay property node and configs to support tests/subsys/fs/ext2, tests/fs/fat_fs_api and tests/subsys/sd on RA8 boards Signed-off-by: Quy Tran <[email protected]>

quytranpzz force-pushed the support_renesas_ra8_sdmmc branch from 968b50d to dc724ce Compare December 10, 2024 09:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support SDHC driver for Renesas RA8 devices #79862

Support SDHC driver for Renesas RA8 devices #79862

khoa-nguyen-18 commented Oct 15, 2024 •

edited

Loading

zephyrbot commented Oct 15, 2024 •

edited

Loading

danieldegrasse left a comment

khoa-nguyen-18 commented Oct 17, 2024

danieldegrasse commented Oct 17, 2024

quytranpzz commented Nov 25, 2024

quytranpzz commented Dec 3, 2024

danieldegrasse left a comment

duynguyenxa Dec 5, 2024

duynguyenxa Dec 5, 2024

quytranpzz Dec 10, 2024

quytranpzz Dec 10, 2024

danieldegrasse Dec 10, 2024

thaoluonguw Dec 5, 2024

thaoluonguw Dec 5, 2024

quytranpzz Dec 10, 2024

thaoluonguw Dec 5, 2024

quytranpzz Dec 10, 2024

Support SDHC driver for Renesas RA8 devices #79862

Are you sure you want to change the base?

Support SDHC driver for Renesas RA8 devices #79862

Conversation

khoa-nguyen-18 commented Oct 15, 2024 • edited Loading

zephyrbot commented Oct 15, 2024 • edited Loading

danieldegrasse left a comment

Choose a reason for hiding this comment

khoa-nguyen-18 commented Oct 17, 2024

danieldegrasse commented Oct 17, 2024

quytranpzz commented Nov 25, 2024

quytranpzz commented Dec 3, 2024

danieldegrasse left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

khoa-nguyen-18 commented Oct 15, 2024 •

edited

Loading

zephyrbot commented Oct 15, 2024 •

edited

Loading