Change mimxrt1060_evk and mimxrt1050_evk to use variants for qspi/hyperflash instead of revisions #79517

decsny · 2024-10-07T17:44:09Z

Change mimxrt1060_evk and mimxrt1050_evk to use variants for qspi/hyperflash instead of revisions

Also for the mimxrt1060_evk, change evkb to a revision.

nordicjm · 2024-10-08T05:26:45Z

boards/nxp/mimxrt1050_evk/mimxrt1050_evk_mimxrt1052_qspi.yaml

@@ -4,7 +4,7 @@
 # SPDX-License-Identifier: Apache-2.0
 #

-identifier: mimxrt1050_evk@qspi
+identifier: mimxrt1050_evk_qspi


this would be mimxrt1050_evk/mimxrt1052/qspi

nordicjm · 2024-10-08T05:27:26Z

boards/nxp/mimxrt1060_evk/mimxrt1060_evk_mimxrt1062_hyperflash.yaml

@@ -4,7 +4,7 @@
 # SPDX-License-Identifier: Apache-2.0
 #

-identifier: mimxrt1060_evk@hyperflash
+identifier: mimxrt1060_evk_hyperflash


decsny · 2024-11-21T23:39:24Z

@tejlmand I've updated the PR to add that check, but what I think would be optimal in this case is actually to have a default variant, but it looks like that's not possible. The reason is because for example on the rt1060, the qspi is set up out of box, and to switch to hyperflash requires soldering a board rework

tejlmand · 2024-11-25T14:29:42Z

The reason is because for example on the rt1060, the qspi is set up out of box, and to switch to hyperflash requires soldering a board rework

yes, I know.
and iirc it was exactly because of this soldering that this board was made as revisions in HWMv1.
Re-soldering the board can be considered akin to another board revision.

tejlmand · 2024-11-25T14:38:21Z

found it: #69264 (comment)

seems like that PR also contained a proposal to use variants 😆

tejlmand · 2024-11-25T14:38:59Z

but what I think would be optimal in this case is actually to have a default variant, but it looks like that's not possible.

not atm, no.

tejlmand

Approved.

Feel free to create an enhancement issue for HWMv2 to allow boards to specify that the base-board is not a valid board / allow the board.yml to define a default variant to use when none is given.

decsny · 2024-11-26T16:27:49Z

update: fixed rt1050 board overlay names

decsny · 2024-12-02T14:15:43Z

rebased and added documentation of board target strings

decsny · 2024-12-09T22:57:08Z

@nordicjm there is some tinycrypt related ci issues blocking this PR but in the meantime can you check if your block was addressed

nordicjm · 2024-12-10T07:10:27Z

boards/nxp/mimxrt1050_evk/mimxrt1050_evk_mimxrt1052_qspi_defconfig

+CONFIG_GPIO=y
+CONFIG_ARM_MPU=y
+CONFIG_HW_STACK_PROTECTION=y
+CONFIG_PINCTRL=y


Suggested change

CONFIG_PINCTRL=y

nordicjm · 2024-12-10T07:10:57Z

boards/nxp/mimxrt1050_evk/board.cmake

+  message(FATAL_ERROR "Please specify a board flash variant for the mimxrt1050_evk:\n"
+                      "mimxrt1050_evk//qspi or mimxrt1050_evk//hyperflash\n")


mimxrt1050_evk/mimxrt1052/qspi and mimxrt1050_evk/mimxrt1052/hyperflash

nordicjm · 2024-12-10T07:11:33Z

boards/nxp/mimxrt1050_evk/board.cmake

@@ -3,10 +3,17 @@
 #
 # SPDX-License-Identifier: Apache-2.0
 #
+
+if (NOT ("${BOARD_QUALIFIERS}" MATCHES "qspi"


Suggested change

if (NOT ("${BOARD_QUALIFIERS}" MATCHES "qspi"

if(NOT ("${BOARD_QUALIFIERS}" MATCHES "qspi"

No spaces between if and bracket in cmake

nordicjm · 2024-12-10T07:11:50Z

boards/nxp/mimxrt1060_evk/board.cmake

@@ -4,13 +4,19 @@
 # SPDX-License-Identifier: Apache-2.0
 #

+if (NOT ("${BOARD_QUALIFIERS}" MATCHES "qspi"


nordicjm · 2024-12-10T07:12:08Z

boards/nxp/mimxrt1060_evk/mimxrt1060_evk_mimxrt1062_qspi_defconfig

+CONFIG_GPIO=y
+CONFIG_ARM_MPU=y
+CONFIG_HW_STACK_PROTECTION=y
+CONFIG_PINCTRL=y


nordicjm · 2024-12-10T07:13:00Z

boards/nxp/mimxrt1060_evk/board.cmake

+  message(FATAL_ERROR "Please specify a board flash variant for the mimxrt1060_evk:\n"
+                      "mimxrt1060_evk//qspi or mimxrt1060_evk//hyperflash\n")


Switch from using revisions for hyperflash/qspi to using variants, by popular demand. Signed-off-by: Declan Snyder <[email protected]>

Convert qspi and hyperflash to variants instead of revisions by popular demand. And convert evkb into a revision instead of a different board. Signed-off-by: Declan Snyder <[email protected]>

Info in the release notes about changes to the board identifier of the mimxrt1060_evk and mimxrt1050_evk. Signed-off-by: Declan Snyder <[email protected]>

nordicjm

Minor nit. (better cleaned up in a future PR than rerunning CI again)

nordicjm · 2024-12-11T07:42:25Z

boards/nxp/mimxrt1060_evk/board.cmake

  board_runner_args(jlink "--loader=BankAddr=0x60000000&Loader=QSPI")
-elseif ("${BOARD_REVISION}" STREQUAL "hyperflash")
+elseif ("${BOARD_QUALIFIERS}" MATCHES "hyperflash")


space here should go

decsny requested review from nashif, tejlmand and nordicjm October 7, 2024 17:44

zephyrbot added Release Notes To be mentioned in the release notes platform: NXP NXP labels Oct 7, 2024

zephyrbot requested review from butok, danieldegrasse, DerekSnell, dkalowsk, dleach02, EmilioCBen, kartben, mmahadevan108 and yvanderv October 7, 2024 17:44

zephyrbot assigned dkalowsk and mmahadevan108 Oct 7, 2024

decsny force-pushed the fix/mimxrt10xx_board_variants branch 3 times, most recently from 029d7c6 to e0b7f43 Compare October 7, 2024 22:52

zephyrbot added area: USB Universal Serial Bus area: Samples Samples labels Oct 7, 2024

zephyrbot requested review from jfischer-no and tmon-nordic October 7, 2024 22:52

nordicjm requested changes Oct 8, 2024

View reviewed changes

decsny force-pushed the fix/mimxrt10xx_board_variants branch from e0b7f43 to 295ac05 Compare October 8, 2024 15:25

decsny mentioned this pull request Oct 9, 2024

twister: rework board enumeration #77250

Merged

decsny force-pushed the fix/mimxrt10xx_board_variants branch from 295ac05 to 5ffdadc Compare October 15, 2024 17:42

zephyrbot added the area: I2S label Oct 15, 2024

zephyrbot requested a review from anangl October 15, 2024 17:42

decsny force-pushed the fix/mimxrt10xx_board_variants branch from 5ffdadc to 4166502 Compare October 17, 2024 18:27

decsny force-pushed the fix/mimxrt10xx_board_variants branch 2 times, most recently from 7a67e9a to 4e6a46f Compare November 21, 2024 23:37

tejlmand previously approved these changes Nov 25, 2024

View reviewed changes

decsny dismissed tejlmand’s stale review via 5fb8567 November 26, 2024 16:27

decsny force-pushed the fix/mimxrt10xx_board_variants branch from 4e6a46f to 5fb8567 Compare November 26, 2024 16:27

decsny mentioned this pull request Nov 26, 2024

HWMV2: Support having default variants for board/soc #82075

Open

tejlmand previously approved these changes Nov 27, 2024

View reviewed changes

tmon-nordic previously approved these changes Nov 27, 2024

View reviewed changes

decsny dismissed stale reviews from tmon-nordic and tejlmand via b80e35c December 2, 2024 14:15

decsny force-pushed the fix/mimxrt10xx_board_variants branch from 5fb8567 to b80e35c Compare December 2, 2024 14:15

nordicjm reviewed Dec 10, 2024

View reviewed changes

boards: mimxrt1050_evk: Switch to variants

06fd93c

Switch from using revisions for hyperflash/qspi to using variants, by popular demand. Signed-off-by: Declan Snyder <[email protected]>

decsny force-pushed the fix/mimxrt10xx_board_variants branch from b80e35c to 492e728 Compare December 10, 2024 15:22

decsny requested a review from nordicjm December 10, 2024 15:22

decsny force-pushed the fix/mimxrt10xx_board_variants branch 3 times, most recently from 1d5e1c1 to 93e7d91 Compare December 10, 2024 19:30

decsny added 2 commits December 10, 2024 14:07

boards: mimxrt1060_evk: Convert to variants

dcd84bb

Convert qspi and hyperflash to variants instead of revisions by popular demand. And convert evkb into a revision instead of a different board. Signed-off-by: Declan Snyder <[email protected]>

doc: release-notes-4.1: RT106/50 board identifiers

48f7477

Info in the release notes about changes to the board identifier of the mimxrt1060_evk and mimxrt1050_evk. Signed-off-by: Declan Snyder <[email protected]>

decsny force-pushed the fix/mimxrt10xx_board_variants branch from 93e7d91 to 48f7477 Compare December 10, 2024 20:08

nordicjm approved these changes Dec 11, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Change mimxrt1060_evk and mimxrt1050_evk to use variants for qspi/hyperflash instead of revisions #79517

Change mimxrt1060_evk and mimxrt1050_evk to use variants for qspi/hyperflash instead of revisions #79517

decsny commented Oct 7, 2024

nordicjm Oct 8, 2024

nordicjm Oct 8, 2024

decsny commented Nov 21, 2024

tejlmand commented Nov 25, 2024

tejlmand commented Nov 25, 2024

tejlmand commented Nov 25, 2024

tejlmand left a comment

decsny commented Nov 26, 2024

decsny commented Dec 2, 2024

decsny commented Dec 9, 2024

nordicjm Dec 10, 2024

nordicjm Dec 10, 2024

nordicjm Dec 10, 2024

nordicjm Dec 10, 2024

nordicjm Dec 10, 2024

nordicjm Dec 10, 2024

nordicjm left a comment

nordicjm Dec 11, 2024

		message(FATAL_ERROR "Please specify a board flash variant for the mimxrt1050_evk:\n"
		"mimxrt1050_evk//qspi or mimxrt1050_evk//hyperflash\n")

	if (NOT ("${BOARD_QUALIFIERS}" MATCHES "qspi"
	if(NOT ("${BOARD_QUALIFIERS}" MATCHES "qspi"

		message(FATAL_ERROR "Please specify a board flash variant for the mimxrt1060_evk:\n"
		"mimxrt1060_evk//qspi or mimxrt1060_evk//hyperflash\n")

Change mimxrt1060_evk and mimxrt1050_evk to use variants for qspi/hyperflash instead of revisions #79517

Are you sure you want to change the base?

Change mimxrt1060_evk and mimxrt1050_evk to use variants for qspi/hyperflash instead of revisions #79517

Conversation

decsny commented Oct 7, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

decsny commented Nov 21, 2024

tejlmand commented Nov 25, 2024

tejlmand commented Nov 25, 2024

tejlmand commented Nov 25, 2024

tejlmand left a comment

Choose a reason for hiding this comment

decsny commented Nov 26, 2024

decsny commented Dec 2, 2024

decsny commented Dec 9, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nordicjm left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment