doc: boards: align main board image name with board name #79503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
platform: Renesas RA
zephyrbot
requested review from
duynguyenxa,
KhiemNguyenT,
LucasTambor,
marekmatej,
raffarost,
soburi,
sylvioalves,
thaoluonguw,
uLipe and
wmrsouza
sylvioalves
reviewed
Oct 7, 2024
|
LGTM |
soburi
previously approved these changes
Oct 7, 2024
thaoluonguw
reviewed
Oct 8, 2024
thaoluonguw
previously approved these changes
Oct 8, 2024
wmrsouza
previously approved these changes
Oct 8, 2024
nashif
previously approved these changes
Oct 8, 2024
uLipe
previously approved these changes
Oct 8, 2024
sylvioalves
previously approved these changes
Oct 8, 2024
As per board porting guidelines, the board image should be named after the board. This commit implements the changes for boards found to be non-compliant. Signed-off-by: Benjamin Cabé <[email protected]>
kartben
dismissed stale reviews from sylvioalves, uLipe, nashif, wmrsouza, and thaoluonguw
via
0b55439
kartben
force-pushed
the
board_images_cleanup
branch
from
6fcbba8 to
0b55439
Compare
|
hadn't noticed docs CI failure until now, sorry. Compliance check will still be failing and will need super-power merge rights. |
thaoluonguw
approved these changes
Oct 11, 2024
kartben
requested review from
thaoluonguw,
soburi,
uLipe,
sylvioalves,
nashif and
wmrsouza
uLipe
approved these changes
Oct 14, 2024
wmrsouza
approved these changes
Oct 14, 2024
|
@sylvioalves please re-approve if you have a chance |
sylvioalves
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per board porting guidelines, the board image should be named after the board.
Compliance check failure is a false positive -- one of the images is too large, but resizing it would be counter productive at this point (old version would still live in Git history).