Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drivers: adc: add support for nRF54L internal SAADC inputs #79330

Conversation

nika-nordic
Copy link
Collaborator

Disregard first commit - this PR is based upon: #79121

nRF54L SAADC peripheral allows to choose internal voltage sources (VDD, AVDD, DVDD) as inputs. This PR allows to utilize those by the adc driver

@zephyrbot
Copy link
Collaborator

zephyrbot commented Oct 2, 2024

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@nika-nordic nika-nordic force-pushed the add_saadc_int_inputs_nrf54l_zephyrupstream branch from f12032e to ac539d3 Compare October 2, 2024 14:31
@decsny decsny removed their request for review October 2, 2024 18:09
@nika-nordic nika-nordic force-pushed the add_saadc_int_inputs_nrf54l_zephyrupstream branch from ac539d3 to 1573cbf Compare October 9, 2024 06:39
Copy link
Member

@gmarull gmarull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if binding headers should just be more specific (ie, nrf91, nrf52833, etc.) instead of having _v suffix. It looks like this is the same IP just with more/less channels routed?

include/zephyr/dt-bindings/adc/nrf-saadc-nrf5x.h Outdated Show resolved Hide resolved
dts/arm/nordic/nrf91ns.dtsi Outdated Show resolved Hide resolved
@kruithofa kruithofa removed their request for review October 9, 2024 12:04
@nika-nordic nika-nordic force-pushed the add_saadc_int_inputs_nrf54l_zephyrupstream branch from 1573cbf to c67b5fa Compare October 14, 2024 11:58
@nika-nordic nika-nordic requested review from anangl and gmarull October 14, 2024 11:59
nika-nordic added a commit to nika-nordic/sdk-zephyr that referenced this pull request Oct 14, 2024
Split header files containing symbols denoting SAADC inputs
so that only supported inputs can be used for given device.

Upstream PR: zephyrproject-rtos/zephyr#79330

Signed-off-by: Nikodem Kastelik <[email protected]>
(cherry picked from commit acb096b44eeddf353a54395f51600118f97cea57)
nika-nordic added a commit to nika-nordic/sdk-zephyr that referenced this pull request Oct 14, 2024
…DC inputs

SAADC peripheral for nRF54L Series allows to choose internal
voltages as positive inputs.

Upstream PR: zephyrproject-rtos/zephyr#79330

Signed-off-by: Nikodem Kastelik <[email protected]>
(cherry picked from commit b74efe4cf82efbb3a518e69792d4d3e7c5a76415)
nika-nordic added a commit to nika-nordic/sdk-zephyr that referenced this pull request Oct 14, 2024
… SAADC inputs

SAADC peripheral for nRF54L Series allows to choose internal
voltages as positive inputs and samples shall showcase that.

Upstream PR: zephyrproject-rtos/zephyr#79330

Signed-off-by: Nikodem Kastelik <[email protected]>
(cherry picked from commit c67b5fa3217b21bfe1604126f06cceb2a1f7c3a9)
gmarull
gmarull previously approved these changes Oct 15, 2024
Split header files containing symbols denoting SAADC inputs
so that only supported inputs can be used for given device.

Signed-off-by: Nikodem Kastelik <[email protected]>
@nika-nordic nika-nordic force-pushed the add_saadc_int_inputs_nrf54l_zephyrupstream branch from c67b5fa to 2734897 Compare October 15, 2024 08:59
@nika-nordic nika-nordic requested a review from anangl October 15, 2024 11:08
SAADC peripheral for nRF54L Series allows to choose internal
voltages as positive inputs.

Signed-off-by: Nikodem Kastelik <[email protected]>
SAADC peripheral for nRF54L Series allows to choose internal
voltages as positive inputs and samples shall showcase that.

Signed-off-by: Nikodem Kastelik <[email protected]>
@nika-nordic nika-nordic force-pushed the add_saadc_int_inputs_nrf54l_zephyrupstream branch from 2734897 to a3d5e0e Compare October 15, 2024 13:41
@nika-nordic nika-nordic requested a review from gmarull October 15, 2024 13:42
@henrikbrixandersen henrikbrixandersen merged commit e315982 into zephyrproject-rtos:main Oct 16, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants