Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: Bluetooth: tester: Implement TBS registration #79266

Merged
merged 1 commit into from
Oct 4, 2024
Merged

tests: Bluetooth: tester: Implement TBS registration #79266

merged 1 commit into from
Oct 4, 2024

Conversation

Thalley
Copy link
Collaborator

@Thalley Thalley commented Oct 1, 2024

TBS registration was changed from static to dynamic and the BT Tester application need to be updated to use the dynamic registration.

@Thalley Thalley marked this pull request as ready for review October 1, 2024 12:38
@Thalley
Copy link
Collaborator Author

Thalley commented Oct 1, 2024

@sjanc this hopefully fixes the TBS issues. Can you trigger the bot to run one or more TBS tests to verify?

@zephyrbot zephyrbot added area: Bluetooth Audio area: Bluetooth area: Bluetooth Qualification Bluetooth Qualification -related issues and pull requests labels Oct 1, 2024
@sjanc
Copy link
Collaborator

sjanc commented Oct 1, 2024

#AutoPTS run zephyr TBS/SR/SGGIT/SER/BV-01-C TBS/SR/CP/BV-01-C GTBS/SR/SGGIT/SER/BV-01-C GTBS/SR/CP/BV-01-C

@codecoup-tester
Copy link

Scheduled PR #79266 (comment), board: nrf53, estimated start time: 14:58:42, test case count: 4, estimated duration: 0:03:35

Test cases to be runTBS/SR/SGGIT/SER/BV-01-C
TBS/SR/CP/BV-01-C
GTBS/SR/SGGIT/SER/BV-01-C
GTBS/SR/CP/BV-01-C

@codecoup-tester
Copy link

AutoPTS Bot results:

Failed tests (4)GTBS GTBS/SR/CP/BV-01-C BTP ERROR
GTBS GTBS/SR/SGGIT/SER/BV-01-C BTP ERROR
TBS TBS/SR/CP/BV-01-C BTP ERROR
TBS TBS/SR/SGGIT/SER/BV-01-C BTP ERROR

@Thalley
Copy link
Collaborator Author

Thalley commented Oct 1, 2024

AutoPTS Bot results:
Failed tests (4)
GTBS GTBS/SR/CP/BV-01-C BTP ERROR
GTBS GTBS/SR/SGGIT/SER/BV-01-C BTP ERROR
TBS TBS/SR/CP/BV-01-C BTP ERROR
TBS TBS/SR/SGGIT/SER/BV-01-C BTP ERROR

Welp :(

@Thalley
tests: Bluetooth: tester: Implement TBS registration
50f5fdf 
TBS registration was changed from static to dynamic
and the BT Tester application need to be updated to use
the dynamic registration.

Signed-off-by: Emil Gydesen <[email protected]>
@Thalley
Copy link
Collaborator Author

Thalley commented Oct 1, 2024

AutoPTS Bot results:
Failed tests (4)
GTBS GTBS/SR/CP/BV-01-C BTP ERROR
GTBS GTBS/SR/SGGIT/SER/BV-01-C BTP ERROR
TBS TBS/SR/CP/BV-01-C BTP ERROR
TBS TBS/SR/SGGIT/SER/BV-01-C BTP ERROR

Welp :(

Was due to a bad error check. Should be < 0 instead of != 0 as it will return the index (>= 0) value on success.

@sjanc can you please retrigger?

@sjanc
Copy link
Collaborator

sjanc commented Oct 1, 2024

#AutoPTS run zephyr TBS/SR/SGGIT/SER/BV-01-C TBS/SR/CP/BV-01-C GTBS/SR/SGGIT/SER/BV-01-C GTBS/SR/CP/BV-01-C

@codecoup-tester
Copy link

Scheduled PR #79266 (comment), board: nrf53, estimated start time: 15:26:20, test case count: 4, estimated duration: 0:03:35

Test cases to be runTBS/SR/SGGIT/SER/BV-01-C
TBS/SR/CP/BV-01-C
GTBS/SR/SGGIT/SER/BV-01-C
GTBS/SR/CP/BV-01-C

@codecoup-tester
Copy link

AutoPTS Bot results:
No failed test found.

Successful tests (4)GTBS GTBS/SR/CP/BV-01-C PASS
GTBS GTBS/SR/SGGIT/SER/BV-01-C PASS
TBS TBS/SR/CP/BV-01-C PASS
TBS TBS/SR/SGGIT/SER/BV-01-C PASS (2)

@Thalley Thalley added the bug The issue is a bug, or the PR is fixing a bug label Oct 4, 2024
@fabiobaltieri fabiobaltieri merged commit a4d628e into zephyrproject-rtos:main Oct 4, 2024
19 checks passed
@Thalley Thalley deleted the tbs_bttester branch October 4, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjanc sjanc sjanc approved these changes

@larsgk larsgk larsgk approved these changes

@asbjornsabo asbjornsabo Awaiting requested review from asbjornsabo

@Casper-Bonde-Bose Casper-Bonde-Bose Awaiting requested review from Casper-Bonde-Bose

@fredrikdanebjer fredrikdanebjer Awaiting requested review from fredrikdanebjer

@jhedberg jhedberg Awaiting requested review from jhedberg

@jthm-ot jthm-ot Awaiting requested review from jthm-ot

@kruithofa kruithofa Awaiting requested review from kruithofa

@MariuszSkamra MariuszSkamra Awaiting requested review from MariuszSkamra

@niym-ot niym-ot Awaiting requested review from niym-ot

@pin-zephyr pin-zephyr Awaiting requested review from pin-zephyr

Assignees

@sjanc sjanc

Labels
area: Bluetooth Audio area: Bluetooth Qualification Bluetooth Qualification -related issues and pull requests area: Bluetooth bug The issue is a bug, or the PR is fixing a bug
Projects
Bluetooth LE Audio
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Thalley @sjanc @codecoup-tester @larsgk @fabiobaltieri @zephyrbot