Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing CONFIG_PINCTRL=y from the nxp boards #79065

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Removing CONFIG_PINCTRL=y from the nxp boards #79065

merged 1 commit into from
Oct 15, 2024

Conversation

EmilioCBen
Copy link
Contributor

@EmilioCBen EmilioCBen commented Sep 26, 2024 •
edited
Loading

This PR addresses the NXP portion of 78619.

@EmilioCBen EmilioCBen force-pushed the fix/nxp_config_pinctrl_on_boards branch from 4fab532 to 5fed70f Compare September 26, 2024 14:57
nordicjm
nordicjm previously approved these changes Sep 26, 2024
View reviewed changes
@nordicjm nordicjm mentioned this pull request Sep 26, 2024
Closed
@EmilioCBen EmilioCBen force-pushed the fix/nxp_config_pinctrl_on_boards branch from 5fed70f to b56bfa1 Compare September 26, 2024 15:10
decsny
decsny previously requested changes Sep 26, 2024
View reviewed changes
Copy link
Member

@decsny decsny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this meant to be a draft? where are the driver kconfig changes?

@manuargue manuargue assigned dleach02 and unassigned manuargue Sep 26, 2024
@EmilioCBen EmilioCBen force-pushed the fix/nxp_config_pinctrl_on_boards branch from b56bfa1 to fd85c8c Compare September 30, 2024 20:10
@EmilioCBen EmilioCBen force-pushed the fix/nxp_config_pinctrl_on_boards branch from fd85c8c to c6e1668 Compare October 1, 2024 15:03
@decsny decsny dismissed their stale review October 1, 2024 15:23

outdated

@EmilioCBen
Copy link
Contributor Author

@nordicjm
Hey, it seems that this PR may be ready but as you point out here I should move the Board's Enablement of PINCTRL from
*_defconfig to the Boards Kconfig, this seems to break Check Compliance. Otherwise Check Compliance will pass.
What do think on the matter?

Also please let me know if I should make any additional changes.

nordicjm
nordicjm requested changes Oct 2, 2024
View reviewed changes
boards/nxp/frdm_kl25z/Kconfig.frdm_kl25z Outdated Show resolved Hide resolved
boards/nxp/twr_ke18f/Kconfig.twr_ke18f Outdated Show resolved Hide resolved
@danieldegrasse danieldegrasse mentioned this pull request Oct 3, 2024
Open
@dleach02
Copy link
Member

dleach02 commented Oct 9, 2024

@EmilioCBen please address CI failures.

Also "meant to fix" should be "fixes #"

@EmilioCBen EmilioCBen force-pushed the fix/nxp_config_pinctrl_on_boards branch from c6e1668 to 048631c Compare October 9, 2024 16:06
@EmilioCBen
boards: nxp: Removing CONFIG_PINCTRL from the boards defconfig
be8863f 
The Drivers using Pinctrl should be turning Pinctrl on
this should not be the responsibility of the board. This
commit removes CONFIG_PINCTRL from the boards side for nxp boards.

Signed-off-by: Emilio Benavente <[email protected]>
@EmilioCBen EmilioCBen force-pushed the fix/nxp_config_pinctrl_on_boards branch from 048631c to be8863f Compare October 11, 2024 14:40
@EmilioCBen
Copy link
Contributor Author

@EmilioCBen please address CI failures.

Also "meant to fix" should be "fixes #"

Updated

@EmilioCBen
Copy link
Contributor Author

@nordicjm
Thank you for the help on this,
I believed I addressed your comments would you mind taking another look

@dleach02 dleach02 requested review from nordicjm and decsny October 14, 2024 18:49
nordicjm
nordicjm approved these changes Oct 15, 2024
View reviewed changes
Copy link
Collaborator

@nordicjm nordicjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nashif nashif merged commit 82a192c into zephyrproject-rtos:main Oct 15, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@decsny decsny decsny approved these changes

@nordicjm nordicjm nordicjm approved these changes

@dleach02 dleach02 dleach02 approved these changes

@bperseghetti bperseghetti Awaiting requested review from bperseghetti

@butok butok Awaiting requested review from butok

@danieldegrasse danieldegrasse Awaiting requested review from danieldegrasse

@Dat-NguyenDuy Dat-NguyenDuy Awaiting requested review from Dat-NguyenDuy

@dbaluta dbaluta Awaiting requested review from dbaluta

@DerekSnell DerekSnell Awaiting requested review from DerekSnell

@iuliana-prodan iuliana-prodan Awaiting requested review from iuliana-prodan

@JiafeiPan JiafeiPan Awaiting requested review from JiafeiPan

@manuargue manuargue Awaiting requested review from manuargue

@mmahadevan108 mmahadevan108 Awaiting requested review from mmahadevan108

@PetervdPerk-NXP PetervdPerk-NXP Awaiting requested review from PetervdPerk-NXP

@yvanderv yvanderv Awaiting requested review from yvanderv

@tbursztyka tbursztyka Awaiting requested review from tbursztyka

@jukkar jukkar Awaiting requested review from jukkar

@Mani-Sadhasivam Mani-Sadhasivam Awaiting requested review from Mani-Sadhasivam

@dcpleung dcpleung Awaiting requested review from dcpleung

@nashif nashif Awaiting requested review from nashif

@simonguinot simonguinot Awaiting requested review from simonguinot

Assignees

@dleach02 dleach02

Labels
platform: NXP MPU platform: NXP S32 NXP Semiconductors, S32 platform: NXP NXP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@EmilioCBen @dleach02 @nordicjm @decsny @nashif @manuargue @zephyrbot