-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wifi: EAP-TLS testing fixes #78733
wifi: EAP-TLS testing fixes #78733
Conversation
The following west manifest projects have been modified in this Pull Request:
Note: This message is automatically posted and updated by the Manifest GitHub Action. |
754c38c
to
658b5f0
Compare
++ @MaochenWang1 @Rex-Chen-NXP for enterprise |
Just NIT question. How can we use overlay-enterprise.conf? |
As Enterprise is optional, I have added to an overlay, this can be used as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor style nit, looks good otherwise.
509489e
to
34a2036
Compare
@krish2718 unfortunate merge conflict, could you resolve it |
EAP-FAST has extra requirements (TLS 1.3, session tickets etc) and is seldom used, so, remove it from Enterprise list and add a separate Kconfig option. This solves the build error when Enterprise mode is enabled. Signed-off-by: Chaitanya Tata <[email protected]>
This overlay has all necessary configuration needed for Enterprise mode. Two variants are given, once with fixed size network buffers and other with variable size network buffers (still experimental). Signed-off-by: Chaitanya Tata <[email protected]>
EAP-TLS enumeration is now changed due to recent SAE additions. Signed-off-by: Chaitanya Tata <[email protected]>
34a2036
to
703032c
Compare
Enterprise security doesn't have either SAE or PSK, so, using a blanker else throws a false warning. Fix the checks to proper handler enterprise mode. Signed-off-by: Chaitanya Tata <[email protected]>
MbedTLS specifically checks for null-terminator, else it skips PEM format processing and tries to parse it as DER causing parsing failures. Signed-off-by: Chaitanya Tata <[email protected]>
Now, Enterprise mode has a separate overlay. Signed-off-by: Chaitanya Tata <[email protected]>
703032c
to
b8730d9
Compare
Fixes from testing EAP-TLS, also recent SAE changes has broken the doc (enum in Wi-Fi shell), fixes that as well.