Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wifi: EAP-TLS testing fixes #78733

Merged
merged 6 commits into from
Oct 15, 2024
Merged

Conversation

krish2718
Copy link
Collaborator

@krish2718 krish2718 commented Sep 19, 2024

Fixes from testing EAP-TLS, also recent SAE changes has broken the doc (enum in Wi-Fi shell), fixes that as well.

@krish2718
Copy link
Collaborator Author

@zephyrbot
Copy link
Collaborator

zephyrbot commented Sep 19, 2024

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@zephyrbot zephyrbot added manifest manifest-hostap DNM This PR should not be merged (Do Not Merge) labels Sep 19, 2024
@fengming-ye
Copy link
Contributor

++ @MaochenWang1 @Rex-Chen-NXP for enterprise

@fengming-ye
Copy link
Contributor

Just NIT question. How can we use overlay-enterprise.conf?

sachinthegreen
sachinthegreen previously approved these changes Sep 20, 2024
@krish2718
Copy link
Collaborator Author

krish2718 commented Sep 20, 2024

Just NIT question. How can we use overlay-enterprise.conf?

As Enterprise is optional, I have added to an overlay, this can be used as west build -b nrf7002dk/nrf5340/cpuapp -- -DEXTRA_CONF_FILE=overlay-enterprise.conf if you want to build it for Enterprise.

samples/net/wifi/overlay-enterprise.conf Outdated Show resolved Hide resolved
sachinthegreen
sachinthegreen previously approved these changes Oct 8, 2024
sachinthegreen
sachinthegreen previously approved these changes Oct 10, 2024
Copy link
Member

@jukkar jukkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor style nit, looks good otherwise.

modules/hostap/src/supp_api.c Outdated Show resolved Hide resolved
jukkar
jukkar previously approved these changes Oct 11, 2024
sachinthegreen
sachinthegreen previously approved these changes Oct 14, 2024
@jukkar
Copy link
Member

jukkar commented Oct 14, 2024

@krish2718 unfortunate merge conflict, could you resolve it

EAP-FAST has extra requirements (TLS 1.3, session tickets etc) and is
seldom used, so, remove it from Enterprise list and add a separate
Kconfig option.

This solves the build error when Enterprise mode is enabled.

Signed-off-by: Chaitanya Tata <[email protected]>
This overlay has all necessary configuration needed for Enterprise mode.
Two variants are given, once with fixed size network buffers and other
with variable size network buffers (still experimental).

Signed-off-by: Chaitanya Tata <[email protected]>
EAP-TLS enumeration is now changed due to recent SAE additions.

Signed-off-by: Chaitanya Tata <[email protected]>
Enterprise security doesn't have either SAE or PSK, so, using a blanker
else throws a false warning. Fix the checks to proper handler enterprise
mode.

Signed-off-by: Chaitanya Tata <[email protected]>
MbedTLS specifically checks for null-terminator, else it skips PEM
format processing and tries to parse it as DER causing parsing failures.

Signed-off-by: Chaitanya Tata <[email protected]>
Now, Enterprise mode has a separate overlay.

Signed-off-by: Chaitanya Tata <[email protected]>
@carlescufi carlescufi merged commit b643070 into zephyrproject-rtos:main Oct 15, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

7 participants