subsys: Add MCTP as a subsystem, built on libmctp with bindings #75743
Conversation
|
The following west manifest projects have changed revision in this Pull Request:
⛔ DNM label due to: 1 added project Note: This message is automatically posted and updated by the Manifest GitHub Action. |
zephyrbot
added
manifest
manifest-libmctp
DNM
teburd
force-pushed
the
libmctp_module
branch
6 times, most recently
from
e32c677 to
44752b4
Compare
teburd
force-pushed
the
libmctp_module
branch
2 times, most recently
from
bd7c893 to
153b02d
Compare
|
Need to work out some upstream stuff, but can then have the fork setup in the zephyrproject-rtos github org |
teburd
force-pushed
the
libmctp_module
branch
4 times, most recently
from
91652d2 to
f884e0d
Compare
|
In my original samples I had hacked up the serial binding to work with Zephyr natively, to better integrate with Zephyr however its useful to provide native bindings in a subsys so that's what I've begun to do. |
teburd
force-pushed
the
libmctp_module
branch
2 times, most recently
from
29717fb to
e1f9cbd
Compare
teburd
force-pushed
the
libmctp_module
branch
2 times, most recently
from
0cbc450 to
ac40b51
Compare
|
libmctp is now hosted by the zephyrproject which was the missing puzzle piece to removing the DNM. The TSC has already voted on this. |
Adds libmctp as a west module dependency Signed-off-by: Tom Burdick <[email protected]>
teburd
force-pushed
the
libmctp_module
branch
from
ac40b51 to
e2db6f4
Compare
teburd
force-pushed
the
libmctp_module
branch
from
e2db6f4 to
f8c48b0
Compare
|
Small fixes to comments/board overlays since the initial PR passed CI and you +1'ed @dkalowsk, thanks! |
There was a problem hiding this comment.
May I please request a README for the code sample? I appreciate the effort on the Doxygen docs—I really do!— but I think this needs slightly more, and the readme will be a great way to make this new subsystem more visible (and it is strictly speaking a requirement for all code samples anyway ;))
teburd
force-pushed
the
libmctp_module
branch
from
f8c48b0 to
300a260
Compare
libmctp provides interfaces for wiring up a MCTP bus it calls bus bindings. The bindings provided in libmctp however are not directly useful to Zephyr without some work. Provide an initial uart binding that directly uses Zephyr's async uart interface. Signed-off-by: Tom Burdick <[email protected]>
Samples work by sending MCTP encoded messages over a uart between two boards. Signed-off-by: Tom Burdick <[email protected]>
Adds myself, nashif, and inteljiangwe1 to the maintainers file covering the libmctp module. Signed-off-by: Tom Burdick <[email protected]>
teburd
force-pushed
the
libmctp_module
branch
from
300a260 to
8bac7a4
Compare
Done |
| { | ||
| switch (eid) { | ||
| case REMOTE_HELLO_EID: | ||
| LOG_INF("got mctp message %s for eid %d, replying to 5 with \"world\"", (char *)msg, |
There was a problem hiding this comment.
What does "replying to 5 with" mean here?
There was a problem hiding this comment.
The endpoint it’s replying to, though I get that’s not necessarily clear
Adds libmctp as a zephyr module from my fork with a few small changes I intend on trying to upstream along with a binding to Zephyr's
pollingasync UART API. Comes with a pair of sample applications that can be used on two boards connected via UART.