Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove CONFIG_PINCTRL from all defconfig files #78619

Closed
nordicjm opened this issue Sep 18, 2024 · 17 comments · Fixed by #79223, #79424, #80697, #80703 or #80715
Closed

Remove CONFIG_PINCTRL from all defconfig files #78619

nordicjm opened this issue Sep 18, 2024 · 17 comments · Fixed by #79223, #79424, #80697, #80703 or #80715
Assignees
@gmarull @nordicjm
Labels
Architecture Review Discussion in the Architecture WG required area: Boards area: Pinctrl bug The issue is a bug, or the PR is fixing a bug Meta A collection of features, enhancements or bugs priority: low Low impact/importance bug
Milestone
v4.1.0

Comments

@nordicjm
Copy link
Collaborator

nordicjm commented Sep 18, 2024 •
edited
Loading

Describe the bug
This Kconfig has wrongly been added to defconfig files, it is not the right place for it, it has never been the right place for it, drivers that need it should select the symbol in their Kconfig entries. The following boards do this wrongly and need to be fixed:

#80664

  • boards/96boards/meerkat96/96b_meerkat96_mcimx7d_m4_defconfig
  • boards/arduino/nicla_sense_me/arduino_nicla_sense_me_defconfig
  • boards/element14/warp7/warp7_mcimx7d_m4_defconfig
  • boards/madmachine/mm_feather/mm_feather_defconfig
  • boards/madmachine/mm_swiftio/mm_swiftio_defconfig
  • boards/phytec/mimx8mm_phyboard_polis/mimx8mm_phyboard_polis_mimx8mm6_m4_defconfig
  • boards/phytec/mimx8mp_phyboard_pollux/mimx8mp_phyboard_pollux_mimx8ml8_m7_defconfig
  • boards/pjrc/teensy4/teensy40_defconfig
  • boards/pjrc/teensy4/teensy41_defconfig
  • boards/segger/ip_k66f/ip_k66f_defconfig
  • boards/technexion/pico_pi/pico_pi_mcimx7d_m4_defconfig
  • boards/toradex/colibri_imx7d/colibri_imx7d_mcimx7d_m4_defconfig
  • boards/toradex/verdin_imx8mp/verdin_imx8mp_mimx8ml8_m7_ddr_defconfig
  • boards/toradex/verdin_imx8mp/verdin_imx8mp_mimx8ml8_m7_defconfig
  • boards/udoo/udoo_neo_full/udoo_neo_full_mcimx6x_m4_defconfig

@soburi #76794

  • boards/arduino/uno_r4/arduino_uno_r4_minima_defconfig
  • boards/arduino/uno_r4/arduino_uno_r4_wifi_defconfig

@jadonk #79407

  • boards/beagle/beagleconnect_freedom/beagleconnect_freedom_defconfig

@nordicjm #78634

  • boards/digilent/zybo/zybo_defconfig

@nordicjm #78634

  • boards/enclustra/mercury_xu/mercury_xu_defconfig

@nordicjm #78621

  • boards/ezurio/rm1xx_dvk/rm1xx_dvk_defconfig

@ifyall

  • boards/infineon/cy8ckit_062s4/cy8ckit_062s4_defconfig
  • boards/infineon/cy8cproto_062_4343w/cy8cproto_062_4343w_defconfig
  • boards/infineon/cy8cproto_063_ble/cy8cproto_063_ble_defconfig
  • boards/infineon/cyw920829m2evk_02/cyw920829m2evk_02_defconfig

@jvasanth1 #82086

  • boards/microchip/mec1501modular_assy6885/mec1501modular_assy6885_defconfig
  • boards/microchip/mec15xxevb_assy6853/mec15xxevb_assy6853_defconfig
  • boards/microchip/mec172xevb_assy6906/mec172xevb_assy6906_defconfig
  • boards/microchip/mec172xmodular_assy6930/mec172xmodular_assy6930_defconfig
  • boards/mikroe/clicker_ra4m1/mikroe_clicker_ra4m1_defconfig

@nordicjm #78621

  • boards/nordic/nrf7002dk/nrf7002dk_nrf5340_cpuapp_defconfig
  • boards/nordic/nrf7002dk/nrf7002dk_nrf5340_cpuapp_nrf7001_defconfig
  • boards/nordic/nrf7002dk/nrf7002dk_nrf5340_cpuapp_nrf7001_ns_defconfig
  • boards/nordic/nrf7002dk/nrf7002dk_nrf5340_cpuapp_ns_defconfig
  • boards/nordic/nrf7002dk/nrf7002dk_nrf5340_cpunet_defconfig
  • boards/nordic/nrf9131ek/nrf9131ek_nrf9131_defconfig
  • boards/nordic/nrf9131ek/nrf9131ek_nrf9131_ns_defconfig

@MulinChao @ChiHuaL #80726

  • boards/nuvoton/npcx4m8f_evb/npcx4m8f_evb_defconfig
  • boards/nuvoton/npcx7m6fb_evb/npcx7m6fb_evb_defconfig
  • boards/nuvoton/npcx9m6f_evb/npcx9m6f_evb_defconfig

@cyliangtw #80903

  • boards/nuvoton/numaker_m2l31ki/numaker_m2l31ki_defconfig
  • boards/nuvoton/numaker_pfm_m467/numaker_pfm_m467_defconfig
  • boards/nuvoton/numaker_pfm_m487/numaker_pfm_m487_defconfig

@decsny @EmilioCBen #79065

  • boards/nxp/frdm_k22f/frdm_k22f_defconfig
  • boards/nxp/frdm_k64f/frdm_k64f_defconfig
  • boards/nxp/frdm_k82f/frdm_k82f_defconfig
  • boards/nxp/frdm_ke15z/frdm_ke15z_defconfig
  • boards/nxp/frdm_ke17z/frdm_ke17z_defconfig
  • boards/nxp/frdm_ke17z512/frdm_ke17z512_defconfig
  • boards/nxp/frdm_kl25z/frdm_kl25z_defconfig
  • boards/nxp/frdm_kw41z/frdm_kw41z_defconfig
  • boards/nxp/frdm_mcxa156/frdm_mcxa156_defconfig
  • boards/nxp/frdm_mcxn236/frdm_mcxn236_defconfig
  • boards/nxp/frdm_mcxn947/frdm_mcxn947_mcxn947_cpu0_defconfig
  • boards/nxp/frdm_mcxn947/frdm_mcxn947_mcxn947_cpu0_qspi_defconfig
  • boards/nxp/frdm_rw612/frdm_rw612_defconfig
  • boards/nxp/hexiwear/hexiwear_mk64f12_defconfig
  • boards/nxp/hexiwear/hexiwear_mkw40z4_defconfig
  • boards/nxp/imx8mm_evk/imx8mm_evk_mimx8mm6_a53_defconfig
  • boards/nxp/imx8mm_evk/imx8mm_evk_mimx8mm6_a53_smp_defconfig
  • boards/nxp/imx8mm_evk/imx8mm_evk_mimx8mm6_m4_defconfig
  • boards/nxp/imx8mn_evk/imx8mn_evk_mimx8mn6_a53_defconfig
  • boards/nxp/imx8mn_evk/imx8mn_evk_mimx8mn6_a53_smp_defconfig
  • boards/nxp/imx8mp_evk/doc/index.rst
  • boards/nxp/imx8mp_evk/imx8mp_evk_mimx8ml8_a53_defconfig
  • boards/nxp/imx8mp_evk/imx8mp_evk_mimx8ml8_a53_smp_defconfig
  • boards/nxp/imx8mp_evk/imx8mp_evk_mimx8ml8_adsp_defconfig
  • boards/nxp/imx8mp_evk/imx8mp_evk_mimx8ml8_m7_ddr_defconfig
  • boards/nxp/imx8mp_evk/imx8mp_evk_mimx8ml8_m7_defconfig
  • boards/nxp/imx8mq_evk/imx8mq_evk_mimx8mq6_m4_defconfig
  • boards/nxp/imx93_evk/imx93_evk_mimx9352_a55_defconfig
  • boards/nxp/imx93_evk/imx93_evk_mimx9352_m33_defconfig
  • boards/nxp/lpcxpresso54114/lpcxpresso54114_lpc54114_m0_defconfig
  • boards/nxp/lpcxpresso54114/lpcxpresso54114_lpc54114_m4_defconfig
  • boards/nxp/lpcxpresso55s06/lpcxpresso55s06_defconfig
  • boards/nxp/lpcxpresso55s16/lpcxpresso55s16_defconfig
  • boards/nxp/lpcxpresso55s28/lpcxpresso55s28_defconfig
  • boards/nxp/lpcxpresso55s36/lpcxpresso55s36_defconfig
  • boards/nxp/lpcxpresso55s69/lpcxpresso55s69_lpc55s69_cpu0_defconfig
  • boards/nxp/lpcxpresso55s69/lpcxpresso55s69_lpc55s69_cpu0_ns_defconfig
  • boards/nxp/mimxrt1010_evk/mimxrt1010_evk_defconfig
  • boards/nxp/mimxrt1015_evk/mimxrt1015_evk_defconfig
  • boards/nxp/mimxrt1020_evk/mimxrt1020_evk_defconfig
  • boards/nxp/mimxrt1024_evk/mimxrt1024_evk_defconfig
  • boards/nxp/mimxrt1040_evk/mimxrt1040_evk_defconfig
  • boards/nxp/mimxrt1050_evk/mimxrt1050_evk_defconfig
  • boards/nxp/mimxrt1060_evk/mimxrt1060_evk_defconfig
  • boards/nxp/mimxrt1060_evk/mimxrt1060_evkb_defconfig
  • boards/nxp/mimxrt1062_fmurt6/mimxrt1062_fmurt6_defconfig
  • boards/nxp/mimxrt1064_evk/mimxrt1064_evk_defconfig
  • boards/nxp/mimxrt1160_evk/mimxrt1160_evk_mimxrt1166_cm4_defconfig
  • boards/nxp/mimxrt1160_evk/mimxrt1160_evk_mimxrt1166_cm7_defconfig
  • boards/nxp/mimxrt1170_evk/mimxrt1170_evk_mimxrt1176_cm4_defconfig
  • boards/nxp/mimxrt1170_evk/mimxrt1170_evk_mimxrt1176_cm7_defconfig
  • boards/nxp/mimxrt1180_evk/mimxrt1180_evk_mimxrt1189_cm33_defconfig
  • boards/nxp/mimxrt1180_evk/mimxrt1180_evk_mimxrt1189_cm7_defconfig
  • boards/nxp/mimxrt595_evk/mimxrt595_evk_mimxrt595s_cm33_defconfig
  • boards/nxp/mimxrt685_evk/mimxrt685_evk_mimxrt685s_cm33_defconfig
  • boards/nxp/mr_canhubk3/mr_canhubk3_defconfig
  • boards/nxp/rd_rw612_bga/rd_rw612_bga_defconfig
  • boards/nxp/rd_rw612_bga/rd_rw612_bga_rw612_ethernet_defconfig
  • boards/nxp/rddrone_fmuk66/rddrone_fmuk66_defconfig
  • boards/nxp/s32z2xxdc2/s32z2xxdc2_s32z270_rtu0_defconfig
  • boards/nxp/s32z2xxdc2/s32z2xxdc2_s32z270_rtu1_defconfig
  • boards/nxp/twr_ke18f/twr_ke18f_defconfig
  • boards/nxp/twr_kv58f220m/twr_kv58f220m_defconfig
  • boards/nxp/ucans32k1sic/ucans32k1sic_defconfig
  • boards/nxp/usb_kw24d512/usb_kw24d512_defconfig
  • boards/nxp/vmu_rt1170/vmu_rt1170_mimxrt1176_cm7_defconfig

#81587

  • boards/openisa/rv32m1_vega/rv32m1_vega_openisa_rv32m1_ri5cy_defconfig
  • boards/openisa/rv32m1_vega/rv32m1_vega_openisa_rv32m1_zero_riscy_defconfig

@vaishnavachath #80664

  • boards/phytec/phyboard_electra/phyboard_electra_am6442_m4_defconfig
  • boards/phytec/phyboard_lyra/phyboard_lyra_am6234_m4_defconfig

@fkokosinski @kgugala @tgorochowik #78630

  • boards/qemu/riscv32_xip/qemu_riscv32_xip_defconfig

@soburi @KhiemNguyenT

  • boards/renesas/ek_ra2a1/ek_ra2a1_defconfig
  • boards/renesas/ek_ra4e2/ek_ra4e2_defconfig
  • boards/renesas/ek_ra4m2/ek_ra4m2_defconfig
  • boards/renesas/ek_ra4m3/ek_ra4m3_defconfig
  • boards/renesas/ek_ra4w1/ek_ra4w1_defconfig
  • boards/renesas/ek_ra6e2/ek_ra6e2_defconfig
  • boards/renesas/ek_ra6m1/ek_ra6m1_defconfig
  • boards/renesas/ek_ra6m2/ek_ra6m2_defconfig
  • boards/renesas/ek_ra6m3/ek_ra6m3_defconfig
  • boards/renesas/ek_ra6m4/ek_ra6m4_defconfig
  • boards/renesas/ek_ra6m5/ek_ra6m5_defconfig
  • boards/renesas/ek_ra8d1/ek_ra8d1_defconfig
  • boards/renesas/ek_ra8m1/ek_ra8m1_defconfig
  • boards/renesas/fpb_ra6e1/fpb_ra6e1_defconfig
  • boards/renesas/fpb_ra6e2/fpb_ra6e2_defconfig
  • boards/renesas/mck_ra8t1/mck_ra8t1_defconfig

@nordicjm #78621

  • boards/ruuvi/ruuvitag/ruuvi_ruuvitag_defconfig

@fkokosinski @kgugala @tgorochowik #78630

  • boards/sifive/hifive1/hifive1_defconfig

@jhedberg #81764

  • boards/silabs/dev_kits/sltb010a/sltb010a_defconfig
  • boards/silabs/dev_kits/xg24_dk2601b/xg24_dk2601b_defconfig
  • boards/silabs/dev_kits/xg27_dk2602a/xg27_dk2602a_defconfig
  • boards/silabs/radio_boards/slwrb4180a/slwrb4180a_defconfig
  • boards/silabs/radio_boards/xg24_rb4187c/xg24_rb4187c_defconfig
  • boards/sparkfun/thing_plus_matter_mgm240p/sparkfun_thing_plus_matter_mgm240p_defconfig

@ruuddw @evgeniy-paltsev #82132

  • boards/snps/emsdp/emsdp_emsdp_em11d_defconfig

@fkokosinski @kgugala @tgorochowik #78630

  • boards/sparkfun/red_v_things_plus/sparkfun_red_v_things_plus_defconfig

#79407

  • boards/ti/cc1352p7_launchpad/cc1352p7_lp_defconfig

@vaishnavachath

  • boards/ti/cc1352p1_launchxl/cc1352p1_launchxl_defconfig
  • boards/ti/cc1352r1_launchxl/cc1352r1_launchxl_defconfig
  • boards/ti/cc1352r_sensortag/cc1352r_sensortag_defconfig
  • boards/ti/cc26x2r1_launchxl/cc26x2r1_launchxl_defconfig
  • boards/ti/sk_am62/sk_am62_am6234_m4_defconfig

@nordicjm #78621

  • boards/vcc-gnd/yd_stm32h750vb/yd_stm32h750vb_defconfig

@ydamigos #79424

  • zephyr/soc/renesas/smartbond/Kconfig.defconfig

@nandojve

@nandojve

@ifyall #81681

  • soc/infineon/cat3/Kconfig.defconfig

@Dino-Li @GTLin08 @RuibinChang

  • soc/ite/ec/it8xxx2/Kconfig.defconfig.series

@jvasanth1 @VenkatKotakonda @albertofloyd

  • soc/microchip/mec/mec174x/Kconfig.defconfig.mec1743qlj
  • soc/microchip/mec/mec174x/Kconfig.defconfig.mec1743qsz
  • soc/microchip/mec/mec175x/Kconfig.defconfig.mec1753qlj
  • soc/microchip/mec/mec175x/Kconfig.defconfig.mec1753qsz
  • soc/microchip/mec/mech172x/Kconfig.defconfig.mech1723nlj
  • soc/microchip/mec/mech172x/Kconfig.defconfig.mech1723nsz

@soburi

@soburi @KhiemNguyenT

  • soc/renesas/ra/ra2a1/Kconfig.defconfig
  • soc/renesas/ra/ra4e2/Kconfig.defconfig
  • soc/renesas/ra/ra4m2/Kconfig.defconfig
  • soc/renesas/ra/ra4m3/Kconfig.defconfig
  • soc/renesas/ra/ra4w1/Kconfig.defconfig
  • soc/renesas/ra/ra6e1/Kconfig.defconfig
  • soc/renesas/ra/ra6e2/Kconfig.defconfig
  • soc/renesas/ra/ra6m1/Kconfig.defconfig
  • soc/renesas/ra/ra6m2/Kconfig.defconfig
  • soc/renesas/ra/ra6m3/Kconfig.defconfig
  • soc/renesas/ra/ra6m4/Kconfig.defconfig
  • soc/renesas/ra/ra6m5/Kconfig.defconfig
  • soc/renesas/ra/ra8d1/Kconfig.defconfig
  • soc/renesas/ra/ra8m1/Kconfig.defconfig
  • soc/renesas/ra/ra8t1/Kconfig.defconfig

@aaillet @lorc #81666

  • soc/renesas/rcar/rcar_gen3/Kconfig.defconfig
  • soc/renesas/rcar/rcar_gen4/Kconfig.defconfig.r8a779f0

@andy-liu-telink

  • soc/telink/tlsr/tlsr951x/Kconfig.defconfig

@vaishnavachath

  • soc/ti/k3/am6x/Kconfig.defconfig

Please submit fixes then tick once they have been merged.
@nordicjm nordicjm added bug The issue is a bug, or the PR is fixing a bug Meta A collection of features, enhancements or bugs labels Sep 18, 2024
@nordicjm nordicjm added this to the v4.0.0 milestone Sep 18, 2024
@nordicjm nordicjm mentioned this issue Sep 18, 2024
Open
@billwatersiii
Copy link
Contributor

These boards are not owned by Infineon (ifyall):

boards/madmachine/mm_feather/mm_feather_defconfig
boards/madmachine/mm_swiftio/mm_swiftio_defconfig

@nordicjm
Copy link
Collaborator Author

nordicjm commented Sep 19, 2024 •
edited
Loading

These boards are not owned by Infineon (ifyall):

boards/madmachine/mm_feather/mm_feather_defconfig boards/madmachine/mm_swiftio/mm_swiftio_defconfig

There is actually a gap there but for some reason github is added a gap between the infineon ones too, but if you edit the post it will show no line gaps for the infineon boards but one after before the madmachine ones. Have added horizontal rulers and now they're aligned... github...

@billwatersiii billwatersiii mentioned this issue Sep 19, 2024
Merged
@decsny decsny mentioned this issue Sep 20, 2024
Closed
@dkalowsk dkalowsk added the priority: low Low impact/importance bug label Sep 24, 2024
@EmilioCBen EmilioCBen mentioned this issue Sep 26, 2024
Merged
iandmorris added a commit to iandmorris/zephyr that referenced this issue Sep 27, 2024
@iandmorris
boards: mikroe: remove CONFIG_PINCTRL from defconfig of RA4M1 clicker
5613ad1 
This PR fixes zephyrproject-rtos#78619 for the Mikroe RA4M1 Clicker board.

Signed-off-by: Ian Morris <[email protected]>
iandmorris added a commit to iandmorris/zephyr that referenced this issue Sep 27, 2024
@iandmorris
boards: mikroe: remove CONFIG_PINCTRL from defconfig of RA4M1 clicker
a337562 
This PR fixes zephyrproject-rtos#78619 for the Mikroe RA4M1 Clicker board.

Signed-off-by: Ian Morris <[email protected]>
iandmorris added a commit to iandmorris/zephyr that referenced this issue Sep 30, 2024
@iandmorris
boards: mikroe: remove CONFIG_PINCTRL from defconfig of RA4M1 clicker
c840f7a 
This PR fixes zephyrproject-rtos#78619 for the Mikroe RA4M1 Clicker board.

Signed-off-by: Ian Morris <[email protected]>
@iandmorris iandmorris mentioned this issue Sep 30, 2024
Merged
This was referenced Oct 1, 2024
Closed
Closed
Closed
Closed
Closed
ydamigos added a commit to ydamigos/zephyr that referenced this issue Oct 4, 2024
@ydamigos
da1469x: Remove CONFIG_PINCTRL from all defconfig files
90187b3 
Remove CONFIG_PINCTRL from all defconfig files.

Fixes zephyrproject-rtos#78619

Signed-off-by: Ioannis Damigos <[email protected]>
@ydamigos ydamigos mentioned this issue Oct 4, 2024
Merged
@nashif nashif closed this as completed in 627c332 Oct 5, 2024
@nordicjm nordicjm reopened this Oct 7, 2024
JA-NXP pushed a commit to nxp-upstream/zephyr that referenced this issue Nov 19, 2024
@ChiHuaL @JA-NXP
board: npcx: remove CONFIG_PINCTRL from defconfig of npcx boards
6f90319 
The CONFIG_PINCTRL is removed from the board's defconfig files.
Drivers which use pin control function should add "select PINCTRL"
in their Kconfig files.

Fixes zephyrproject-rtos#78619

Signed-off-by: Jun Lin <[email protected]>
@github-project-automation github-project-automation bot moved this from Todo to Done in Architecture Review Nov 20, 2024
@nordicjm nordicjm reopened this Nov 20, 2024
@nashif nashif closed this as completed in 355d032 Nov 20, 2024
@nordicjm nordicjm reopened this Nov 20, 2024
aaillet added a commit to iotbzh/zephyr that referenced this issue Nov 20, 2024
@aaillet
soc: renesas: rcar: Remove CONFIG_PINCTRL
794d666 
Remove CONFIG_PINCTRL from rcar defconfig files
Fixes: zephyrproject-rtos#78619

Signed-off-by: Aymeric Aillet <[email protected]>
aaillet added a commit to iotbzh/zephyr that referenced this issue Nov 20, 2024
@aaillet
soc: renesas: rcar: Remove CONFIG_PINCTRL
6f5cb89 
Remove CONFIG_PINCTRL from rcar defconfig files
Fixes: zephyrproject-rtos#78619

Signed-off-by: Aymeric Aillet <[email protected]>
@aaillet aaillet mentioned this issue Nov 20, 2024
Merged
mcatee-infineon added a commit to mcatee-infineon/zephyr that referenced this issue Nov 20, 2024
@mcatee-infineon
SOC: Remove config PINCTRL from xmc4xxx soc
b0cdd5d 
	- Move selection of CONFIG_PINCTRL from soc to individual
	  drivers
	- in accordance with issue zephyrproject-rtos#78619

Signed-off-by:McAtee Maxwell <[email protected]>
mcatee-infineon added a commit to mcatee-infineon/zephyr that referenced this issue Nov 20, 2024
@mcatee-infineon
SOC: Remove config PINCTRL from xmc4xxx soc
9d4780a 
	- Move selection of CONFIG_PINCTRL from soc to individual
	  drivers
	- in accordance with issue zephyrproject-rtos#78619

Signed-off-by: McAtee Maxwell <[email protected]>
@jhedberg jhedberg mentioned this issue Nov 22, 2024
Merged
@tagunil
Copy link
Collaborator

tagunil commented Nov 22, 2024

boards/snps/emsdp/emsdp_emsdp_em11d_defconfig

Hi @nordicjm,
What should we do if our SoCs use generic drivers like spi_dw or uart_ns16550, which might require PINCTRL depending on specific hardware configuration of these IPs? We'd really like to avoid making PINCTRL a hard requirement for the drivers, keeping the dependency somewhere between the SoC level and the board level.

@gmarull
Copy link
Member

gmarull commented Nov 22, 2024

boards/snps/emsdp/emsdp_emsdp_em11d_defconfig

Hi @nordicjm, What should we do if our SoCs use generic drivers like spi_dw or uart_ns16550, which might require PINCTRL depending on specific hardware configuration of these IPs? We'd really like to avoid making PINCTRL a hard requirement for the drivers, keeping the dependency somewhere between the SoC level and the board level.

select PINCTRL if ...

@tagunil
Copy link
Collaborator

tagunil commented Nov 22, 2024

boards/snps/emsdp/emsdp_emsdp_em11d_defconfig

Hi @nordicjm, What should we do if our SoCs use generic drivers like spi_dw or uart_ns16550, which might require PINCTRL depending on specific hardware configuration of these IPs? We'd really like to avoid making PINCTRL a hard requirement for the drivers, keeping the dependency somewhere between the SoC level and the board level.

select PINCTRL if ...

Do you mean listing the SoCs in the Kconfig of the driver? Wouldn't such a list grow uncontrollably for drivers used by many different SoCs from different vendors, like ns16550?

@gmarull
Copy link
Member

gmarull commented Nov 22, 2024

boards/snps/emsdp/emsdp_emsdp_em11d_defconfig

Hi @nordicjm, What should we do if our SoCs use generic drivers like spi_dw or uart_ns16550, which might require PINCTRL depending on specific hardware configuration of these IPs? We'd really like to avoid making PINCTRL a hard requirement for the drivers, keeping the dependency somewhere between the SoC level and the board level.

select PINCTRL if ...

Do you mean listing the SoCs in the Kconfig of the driver? Wouldn't such a list grow uncontrollably for drivers used by many different SoCs from different vendors, like ns16550?

you can always do select PINCTRL if !... I guess they'll be the exception and not the rule. After all, these generic APIs (like pinctrl) exist to facilitate generic IP drivers.

@jhedberg
Copy link
Member

Considering that we have a bunch of Kconfig macros for DT, I wonder if it'd be possible to use those to detect if a DT node with the ns16550 compat has a pinctrl-N property, and if so select PINCTRL?

@jhedberg
Copy link
Member

Considering that we have a bunch of Kconfig macros for DT, I wonder if it'd be possible to use those to detect if a DT node with the ns16550 compat has a pinctrl-N property, and if so select PINCTRL?

What I mean is, something like this:

select PINCTRL if $(dt_compat_any_has_prop,$(DT_COMPAT_NS16550),pinctrl-0)

@fabiobaltieri fabiobaltieri reopened this Nov 22, 2024
@jhedberg jhedberg reopened this Nov 26, 2024
@tagunil tagunil mentioned this issue Nov 27, 2024
Merged
fabiobaltieri pushed a commit that referenced this issue Dec 2, 2024
@mcatee-infineon @fabiobaltieri
SOC: Remove config PINCTRL from xmc4xxx soc
3024392 
	- Move selection of CONFIG_PINCTRL from soc to individual
	  drivers
	- in accordance with issue #78619

Signed-off-by: McAtee Maxwell <[email protected]>
@nordicjm nordicjm linked a pull request Dec 5, 2024 that will close this issue
boards: snps: emsdp: remove CONFIG_PINCTRL from the defconfig #82132
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gmarull gmarull

@nordicjm nordicjm

Labels
Architecture Review Discussion in the Architecture WG required area: Boards area: Pinctrl bug The issue is a bug, or the PR is fixing a bug Meta A collection of features, enhancements or bugs priority: low Low impact/importance bug
Projects
Architecture Review
Status: Done
Milestone
v4.1.0