stm32 flash read out protection rdp in a common file #162466
Annotations
4 errors, 1 warning, and 7 notices
Run Compliance Tests
Process completed with exit code 3.
|
check-warns:
GitDiffCheck.txt#L1
Git conflict markers and whitespace errors are not allowed in added changes
d9ad1578c78ddf947f1f4f1093796d2c2257a3c2: drivers/flash/flash_stm32_ex_op.c:339: new blank line at EOF.
|
check-warns:
Nits.txt#L1
See https://docs.zephyrproject.org/latest/contribute/guidelines.html#coding-style for more details.
Please remove blank lines at end of 'drivers/flash/flash_stm32_ex_op.c'
|
check-warns
Process completed with exit code 1.
|
check-warns:
ClangFormat.txt#L1
See https://docs.zephyrproject.org/latest/contribute/guidelines.html#clang-format for more details.
You may want to run clang-format on this change:
-
File:drivers/flash/flash_stm32.c
Line:59
You may want to run clang-format on this change:
-int flash_stm32_ex_op(const struct device *dev, uint16_t code,
- const uintptr_t in, void *out);
+int flash_stm32_ex_op(const struct device *dev, uint16_t code, const uintptr_t in, void *out);
File:drivers/flash/flash_stm32.h
Line:308
You may want to run clang-format on this change:
-int flash_stm32_ex_op(const struct device *dev, uint16_t code,
- const uintptr_t in, void *out)
+int flash_stm32_ex_op(const struct device *dev, uint16_t code, const uintptr_t in, void *out)
File:drivers/flash/flash_stm32_ex_op.c
Line:234
You may want to run clang-format on this change:
-#if defined(FLASH_CR_OPTWRE) /* F0, F1 and F3 */
+#if defined(FLASH_CR_OPTWRE) /* F0, F1 and F3 */
if (enable) {
regs->CR &= ~FLASH_CR_OPTWRE;
} else if (!(regs->CR & FLASH_CR_OPTWRE)) {
regs->OPTKEYR = FLASH_OPTKEY1;
regs->OPTKEYR = FLASH_OPTKEY2;
}
-#elif defined(FLASH_CR_OPTLOCK) /* G0, G4, L4, WB and WL */
+#elif defined(FLASH_CR_OPTLOCK) /* G0, G4, L4, WB and WL */
if (enable) {
regs->CR |= FLASH_CR_OPTLOCK;
} else if (regs->CR & FLASH_CR_OPTLOCK) {
regs->OPTKEYR = FLASH_OPTKEY1;
regs->OPTKEYR = FLASH_OPTKEY2;
}
-#elif defined(FLASH_PECR_OPTLOCK) /* L0 and L1 */
+#elif defined(FLASH_PECR_OPTLOCK) /* L0 and L1 */
if (enable) {
regs->PECR |= FLASH_PECR_OPTLOCK;
} else if (regs->PECR & FLASH_PECR_OPTLOCK) {
regs->OPTKEYR = FLASH_OPTKEY1;
regs->OPTKEYR = FLASH_OPTKEY2;
}
-#elif defined(FLASH_NSCR_OPTLOCK) /* L5 and U5 */
+#elif defined(FLASH_NSCR_OPTLOCK) /* L5 and U5 */
File:drivers/flash/flash_stm32_ex_op.c
Line:308
You may want to run clang-format on this change:
-
File:drivers/flash/flash_stm32_ex_op.c
Line:340
You may want to run clang-format on this change:
-static __unused int write_optb(const struct device *dev, uint32_t mask,
- uint32_t value)
+static __unused int write_optb(const struct device *dev, uint32_t mask, uint32_t value)
File:drivers/flash/flash_stm32h7x.c
Line:67
You may want to run clang-format on this change:
- write_optb(dev, FLASH_OPTSR_RDP_Msk,
- (uint32_t)level << FLASH_OPTSR_RDP_Pos);
+ write_optb(dev, FLASH_OPTSR_RDP_Msk, (uint32_t)level << FLASH_OPTSR_RDP_Pos);
File:drivers/flash/flash_stm32h7x.c
Line:114
|
Run Compliance Tests:
drivers/flash/flash_stm32.c#L59
drivers/flash/flash_stm32.c:59
-
|
Run Compliance Tests:
drivers/flash/flash_stm32.h#L308
drivers/flash/flash_stm32.h:308
-int flash_stm32_ex_op(const struct device *dev, uint16_t code,
- const uintptr_t in, void *out);
+int flash_stm32_ex_op(const struct device *dev, uint16_t code, const uintptr_t in, void *out);
|
Run Compliance Tests:
drivers/flash/flash_stm32_ex_op.c#L234
drivers/flash/flash_stm32_ex_op.c:234
-int flash_stm32_ex_op(const struct device *dev, uint16_t code,
- const uintptr_t in, void *out)
+int flash_stm32_ex_op(const struct device *dev, uint16_t code, const uintptr_t in, void *out)
|
Run Compliance Tests:
drivers/flash/flash_stm32_ex_op.c#L308
drivers/flash/flash_stm32_ex_op.c:308
-#if defined(FLASH_CR_OPTWRE) /* F0, F1 and F3 */
+#if defined(FLASH_CR_OPTWRE) /* F0, F1 and F3 */
if (enable) {
regs->CR &= ~FLASH_CR_OPTWRE;
} else if (!(regs->CR & FLASH_CR_OPTWRE)) {
regs->OPTKEYR = FLASH_OPTKEY1;
regs->OPTKEYR = FLASH_OPTKEY2;
}
-#elif defined(FLASH_CR_OPTLOCK) /* G0, G4, L4, WB and WL */
+#elif defined(FLASH_CR_OPTLOCK) /* G0, G4, L4, WB and WL */
if (enable) {
regs->CR |= FLASH_CR_OPTLOCK;
} else if (regs->CR & FLASH_CR_OPTLOCK) {
regs->OPTKEYR = FLASH_OPTKEY1;
regs->OPTKEYR = FLASH_OPTKEY2;
}
-#elif defined(FLASH_PECR_OPTLOCK) /* L0 and L1 */
+#elif defined(FLASH_PECR_OPTLOCK) /* L0 and L1 */
if (enable) {
regs->PECR |= FLASH_PECR_OPTLOCK;
} else if (regs->PECR & FLASH_PECR_OPTLOCK) {
regs->OPTKEYR = FLASH_OPTKEY1;
regs->OPTKEYR = FLASH_OPTKEY2;
}
-#elif defined(FLASH_NSCR_OPTLOCK) /* L5 and U5 */
+#elif defined(FLASH_NSCR_OPTLOCK) /* L5 and U5 */
|
Run Compliance Tests:
drivers/flash/flash_stm32_ex_op.c#L340
drivers/flash/flash_stm32_ex_op.c:340
-
|
Run Compliance Tests:
drivers/flash/flash_stm32h7x.c#L67
drivers/flash/flash_stm32h7x.c:67
-static __unused int write_optb(const struct device *dev, uint32_t mask,
- uint32_t value)
+static __unused int write_optb(const struct device *dev, uint32_t mask, uint32_t value)
|
Run Compliance Tests:
drivers/flash/flash_stm32h7x.c#L114
drivers/flash/flash_stm32h7x.c:114
- write_optb(dev, FLASH_OPTSR_RDP_Msk,
- (uint32_t)level << FLASH_OPTSR_RDP_Pos);
+ write_optb(dev, FLASH_OPTSR_RDP_Msk, (uint32_t)level << FLASH_OPTSR_RDP_Pos);
|
Loading