drivers: serial: nrfx_uarte: Rework driver to support new features #155406
Annotations
1 error, 1 warning, and 10 notices
Run Compliance Tests
Process completed with exit code 1.
|
check-warns:
ClangFormat.txt#L1
See https://docs.zephyrproject.org/latest/contribute/guidelines.html#clang-format for more details.
You may want to run clang-format on this change:
-#if (UARTE_FOR_EACH_INSTANCE(INSTANCE_PROP, (+), (0), frame_timeout_supported)) == \
+#if (UARTE_FOR_EACH_INSTANCE(INSTANCE_PROP, (+), (0), frame_timeout_supported)) == \
File:drivers/serial/uart_nrfx_uarte.c
Line:87
You may want to run clang-format on this change:
- int32_t timeout_us; /* Timeout set by user */
+ int32_t timeout_us; /* Timeout set by user */
File:drivers/serial/uart_nrfx_uarte.c
Line:129
You may want to run clang-format on this change:
-#define UARTE_FLAG_TRIG_RXTO BIT(2)
+#define UARTE_FLAG_TRIG_RXTO BIT(2)
File:drivers/serial/uart_nrfx_uarte.c
Line:188
You may want to run clang-format on this change:
-#define HW_RX_COUNTING_ENABLED(config) \
- (IS_ENABLED(UARTE_ANY_HW_ASYNC) ? \
- (config->flags & UARTE_CFG_FLAG_HW_BYTE_COUNTING) : false)
+#define HW_RX_COUNTING_ENABLED(config) \
+ (IS_ENABLED(UARTE_ANY_HW_ASYNC) ? (config->flags & UARTE_CFG_FLAG_HW_BYTE_COUNTING) : false)
File:drivers/serial/uart_nrfx_uarte.c
Line:527
You may want to run clang-format on this change:
-static void timer_handler(nrf_timer_event_t event_type, void *p_context) { }
+static void timer_handler(nrf_timer_event_t event_type, void *p_context)
+{
+}
File:drivers/serial/uart_nrfx_uarte.c
Line:629
You may want to run clang-format on this change:
- static const uint32_t rx_int_mask =
- NRF_UARTE_INT_ENDRX_MASK |
- NRF_UARTE_INT_RXSTARTED_MASK |
- NRF_UARTE_INT_ERROR_MASK |
- NRF_UARTE_INT_RXTO_MASK |
- ((IS_ENABLED(CONFIG_UART_NRFX_UARTE_ENHANCED_RX) &&
- !IS_ENABLED(UARTE_HAS_FRAME_TIMEOUT)) ? NRF_UARTE_INT_RXDRDY_MASK : 0);
+ static const uint32_t rx_int_mask = NRF_UARTE_INT_ENDRX_MASK |
+ NRF_UARTE_INT_RXSTARTED_MASK |
+ NRF_UARTE_INT_ERROR_MASK | NRF_UARTE_INT_RXTO_MASK |
+ ((IS_ENABLED(CONFIG_UART_NRFX_UARTE_ENHANCED_RX) &&
+ !IS_ENABLED(UARTE_HAS_FRAME_TIMEOUT))
+ ? NRF_UARTE_INT_RXDRDY_MASK
+ : 0);
File:drivers/serial/uart_nrfx_uarte.c
Line:683
You may want to run clang-format on this change:
- async_rx->timeout = (timeout == SYS_FOREVER_US) ?
- K_NO_WAIT : K_USEC(timeout / RX_TIMEOUT_DIV);
+ async_rx->timeout =
+ (timeout == SYS_FOREVER_US) ? K_NO_WAIT : K_USEC(timeout / RX_TIMEOUT_DIV);
File:drivers/serial/uart_nrfx_uarte.c
Line:895
You may want to run clang-format on this change:
- async_rx->flush_cnt);
+ async_rx->flush_cnt);
File:drivers/serial/uart_nrfx_uarte.c
Line:924
You may want to run clang-format on this change:
- K_NO_WAIT);
+ K_NO_WAIT);
File:drivers/serial/uart_nrfx_uarte.c
Line:933
You may want to run clang-format on this change:
- (void) uarte_nrfx_tx_abort(dev);
+ (void)uarte_nrfx_tx_abort(dev);
File:drivers/serial/uart_nrfx_uarte.c
Line:1036
You may want to run clang-format on this change:
-#if CONFIG_UART_NRFX_UARTE_ENHANCED_RX
+#if CONFIG_UART_NRFX_UARTE_ENHANCED_RX
File:drivers/serial/uart_nrfx_uarte.c
Line:1051
You may want to run clang-format on this change:
-#else /* UARTE_HAS_FRAME_TIMEOUT */
+#else /* UARTE_HAS_FRAME_TIMEOUT */
File:drivers/serial/uart_nrfx_uarte.c
Line:1059
You may want to run clang-format on this change:
-#else /* CONFIG_UART_NRFX_UARTE_ENHANCED_RX */
+#else /* CONFIG_UART_NRFX_UARTE_ENHANCED_RX */
File:drivers/serial/uart_nrfx_uarte.c
Line:1084
You may want to run clang-format on this change:
-static bool event_check_clear(NRF_UARTE_Type *uarte, nrf_uarte_event_t event,
- uint32_t int_mask, uint32_t int_en_mask)
+static bool event_check_clear(NRF_UARTE_Type *uarte, nrf_uarte_event_t event, uint32_t int_mask,
+ uint32_t int_en_mask)
File:drivers/serial/uart_nrfx_uarte.c
Line:1529
You may want to run clang-format on this change:
- if (!(HW_RX_COUNTING_ENABLED(config) || IS_ENABLED(UARTE_HAS_FRAME_TIMEOUT))
- && event_check_clear(uarte, NRF_UARTE_EVENT_RXDRDY, NRF_UARTE_INT_RXDRDY_MASK, imask)
|
Run Compliance Tests:
drivers/serial/uart_nrfx_uarte.c#L87
drivers/serial/uart_nrfx_uarte.c:87
-#if (UARTE_FOR_EACH_INSTANCE(INSTANCE_PROP, (+), (0), frame_timeout_supported)) == \
+#if (UARTE_FOR_EACH_INSTANCE(INSTANCE_PROP, (+), (0), frame_timeout_supported)) == \
|
Run Compliance Tests:
drivers/serial/uart_nrfx_uarte.c#L129
drivers/serial/uart_nrfx_uarte.c:129
- int32_t timeout_us; /* Timeout set by user */
+ int32_t timeout_us; /* Timeout set by user */
|
Run Compliance Tests:
drivers/serial/uart_nrfx_uarte.c#L188
drivers/serial/uart_nrfx_uarte.c:188
-#define UARTE_FLAG_TRIG_RXTO BIT(2)
+#define UARTE_FLAG_TRIG_RXTO BIT(2)
|
Run Compliance Tests:
drivers/serial/uart_nrfx_uarte.c#L527
drivers/serial/uart_nrfx_uarte.c:527
-#define HW_RX_COUNTING_ENABLED(config) \
- (IS_ENABLED(UARTE_ANY_HW_ASYNC) ? \
- (config->flags & UARTE_CFG_FLAG_HW_BYTE_COUNTING) : false)
+#define HW_RX_COUNTING_ENABLED(config) \
+ (IS_ENABLED(UARTE_ANY_HW_ASYNC) ? (config->flags & UARTE_CFG_FLAG_HW_BYTE_COUNTING) : false)
|
Run Compliance Tests:
drivers/serial/uart_nrfx_uarte.c#L629
drivers/serial/uart_nrfx_uarte.c:629
-static void timer_handler(nrf_timer_event_t event_type, void *p_context) { }
+static void timer_handler(nrf_timer_event_t event_type, void *p_context)
+{
+}
|
Run Compliance Tests:
drivers/serial/uart_nrfx_uarte.c#L683
drivers/serial/uart_nrfx_uarte.c:683
- static const uint32_t rx_int_mask =
- NRF_UARTE_INT_ENDRX_MASK |
- NRF_UARTE_INT_RXSTARTED_MASK |
- NRF_UARTE_INT_ERROR_MASK |
- NRF_UARTE_INT_RXTO_MASK |
- ((IS_ENABLED(CONFIG_UART_NRFX_UARTE_ENHANCED_RX) &&
- !IS_ENABLED(UARTE_HAS_FRAME_TIMEOUT)) ? NRF_UARTE_INT_RXDRDY_MASK : 0);
+ static const uint32_t rx_int_mask = NRF_UARTE_INT_ENDRX_MASK |
+ NRF_UARTE_INT_RXSTARTED_MASK |
+ NRF_UARTE_INT_ERROR_MASK | NRF_UARTE_INT_RXTO_MASK |
+ ((IS_ENABLED(CONFIG_UART_NRFX_UARTE_ENHANCED_RX) &&
+ !IS_ENABLED(UARTE_HAS_FRAME_TIMEOUT))
+ ? NRF_UARTE_INT_RXDRDY_MASK
+ : 0);
|
Run Compliance Tests:
drivers/serial/uart_nrfx_uarte.c#L895
drivers/serial/uart_nrfx_uarte.c:895
- async_rx->timeout = (timeout == SYS_FOREVER_US) ?
- K_NO_WAIT : K_USEC(timeout / RX_TIMEOUT_DIV);
+ async_rx->timeout =
+ (timeout == SYS_FOREVER_US) ? K_NO_WAIT : K_USEC(timeout / RX_TIMEOUT_DIV);
|
Run Compliance Tests:
drivers/serial/uart_nrfx_uarte.c#L924
drivers/serial/uart_nrfx_uarte.c:924
- async_rx->flush_cnt);
+ async_rx->flush_cnt);
|
Run Compliance Tests:
drivers/serial/uart_nrfx_uarte.c#L933
drivers/serial/uart_nrfx_uarte.c:933
- K_NO_WAIT);
+ K_NO_WAIT);
|
Run Compliance Tests:
drivers/serial/uart_nrfx_uarte.c#L1036
drivers/serial/uart_nrfx_uarte.c:1036
- (void) uarte_nrfx_tx_abort(dev);
+ (void)uarte_nrfx_tx_abort(dev);
|
Loading