fix(PeriphDrivers, CMSIS): Fix build warnings and errors #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shutdown function is defined as MXC_LP_EnterShutDownMode lp.h however it is implemented as MXC_LP_EnterPowerDownMode. Signed-off-by: Tahsin Mutlugun <[email protected]>
Remove inclusion of trimsir_regs.h and aes_regs.h from max32672.h. They may cause redefinition warnings for __I macro. Signed-off-by: Tahsin Mutlugun <[email protected]>
|
What was fixed to resolve the redefinition warnings? This is happening in the MSDK too, and it is not obvious what changed. |
I think the order of inclusions was causing the error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses below issues.
MXC_LP_EnterShutDownModehowever it is implemented asMXC_LP_EnterPowerDownModefor MAX32662. This could cause undefined reference errors.