Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardise type of numerical CLI parameters #32

Open
morkeltry opened this issue Apr 20, 2021 · 2 comments
Open

Standardise type of numerical CLI parameters #32

morkeltry opened this issue Apr 20, 2021 · 2 comments
Labels
p:low t:enhancement

Comments

@morkeltry
Copy link
Contributor

e.g. marketId.
They are sometimes string, sometimes number.

Currently strings are converted with Number(). Check that changing type to number does not miss edge cases (eg missing param).
@morkeltry
Copy link
Contributor Author

Doesn't appear to be supported in commander for no-optional arguments.

@lsaether
Copy link
Member

Does this issue reference the SDK or CLI?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p:low t:enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@morkeltry @lsaether