Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom slider styling #165

Open
iamdebodon opened this issue Feb 13, 2019 · 9 comments
Open

Support custom slider styling #165

iamdebodon opened this issue Feb 13, 2019 · 9 comments

Comments

@iamdebodon
Copy link

iamdebodon commented Feb 13, 2019

I am overriding the color picker class with my own new class. But with the approach, it is giving the issue of slider dragging.

Thanks,
Debo

@sconix
Copy link
Contributor

sconix commented Feb 13, 2019

Bit hard to say without being able to test it, but most likely you are adding padding or margin to some class you should not that messes up the calculation.

@iamdebodon
Copy link
Author

Isn't it possible to add some dynamic padding and do some workaround on it, in order to make dragging work?

@sconix
Copy link
Contributor

sconix commented Feb 14, 2019

You should be able to just use padding in parent elements for exa ple not just in the slider elements.

@iamdebodon
Copy link
Author

iamdebodon commented Feb 14, 2019

Just shared a stackbliz link which depict our problem: https://stackblitz.com/edit/github-7ljkgv-ma8ap6?file=src%2Fstyles.scss.

@sconix
Copy link
Contributor

sconix commented Feb 14, 2019

I checked the dialog code and it looks like the dialog was never build for supporting custom sizes for the sliders. So basically you can not modify the sizes of the sliders with style the dialog only uses the width of the dialog to determine the sizes of the sliders.

I will do some improvements for the next major release (8.0.0) so that custom styling that changes slider sizes should work. So until that you just need to play with the styles and see what you can do and what you can not.

@sconix sconix changed the title Hue Slider dragging issue Support custom slider styling Feb 14, 2019
@bhaskerchari
Copy link

bhaskerchari commented Feb 15, 2019

@sconix ,

First of all thanks for the great component which solves cross browser compatible issues.

I am also looking for something similar where I want to apply my own styles to the dialog and noticed the same issue as mentioned in this post.

I see like you mentioned you are making some improvements in release (8.0.0). Is there any tentative release date that you have in mind? Please let us know.

Is there something that you can do changes or suggest anything to the sample in stackblitz url which is shared by @iamdebodon which we can use them as a work around until then?

Thanks in advance.

@sconix
Copy link
Contributor

sconix commented Feb 15, 2019

Release happens around when Angular 8 is out (+-1 week). Do not have time to work on this before that. Naturally PR's are excepted if somebody provides one.

So until that you just have to live with some of the styling limitation that you do not manage to get working. Only advice I can give is that some sliders might work better with some custom styles if custom dialog width is used. So with other than 230 width the code does read some of the slider widths from the DOM, but I did not test this and since the code is still mostly originally not made by me I do not know it fully that will those width updates even help in this case.

@bhaskerchari
Copy link

@sconix sounds good thanks for the update. I will look forward to the change then :)

Thanks,
Bhasker

@ST185314
Copy link

How to make this colorpicker and slider keyboard accessible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants