Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ZIP 227] Finalization should occur immediately, not at the next block boundary #958

Open
daira opened this issue Nov 12, 2024 · 2 comments

Comments

@daira
Copy link
Collaborator

daira commented Nov 12, 2024

Existing implementations in practice consider transactions within a block to act on the global state sequentially, and they perform consensus checks accordingly. (Pointed out by @str4d.)

@daira
Copy link
Collaborator Author

daira commented Nov 12, 2024

This is a similar state-access-ordering issue to #957, and this comment from there applies:

This [ambiguity] is a consequence of the use of imperative statements like "reduce the value" or "increase the value" [in consensus rules]. I don't want to claim these are strictly never used in existing consensus rules, but it is undesirable to use them because of ambiguities like that above [between issuance and the check for burn validity]. It is far preferable to refer explicitly to indexed states, i.e. to define notation for the global state before and after the transaction. Then a consensus rule that performs an "update" can be rephrased as imposing a relation between the before-state and after-state, which resolves a lot of potential ambiguities (in particular, conflicting requirements automatically do the right thing which is to reject the transaction).

vivek-arte added a commit to QED-it/zips that referenced this issue Nov 13, 2024
…ock boundary (#81)

This completes the changes needed to make sure the finalization comes
into effect immediately. A part of this was done in
#75, the remainder is covered here.

This solves zcash#958.
@vivek-arte
Copy link
Contributor

We made the remaining changes to resolve this in QED-it#81. This has been merged into our main working branch, and is thus now included in #960.

vivek-arte added a commit to QED-it/zips that referenced this issue Nov 21, 2024
…ock boundary (#81)

This completes the changes needed to make sure the finalization comes
into effect immediately. A part of this was done in
#75, the remainder is covered here.

This solves zcash#958.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants