Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move lazy_static/spin_no_std out of default features and behind a separate feature flag #81

Open
str4d opened this issue Apr 16, 2024 · 0 comments

Comments

@str4d
Copy link
Contributor

str4d commented Apr 16, 2024

We currently enable lazy_static/spin_no_std at the request of downstream users who want to use pasta_curves in an alloc no-std environment. However, other downstream users want to not have that flag enabled as they don't want to depend on spin.

rust-lang/cargo#8170 means that we cannot disable a dependency feature flag when we enable one of our own feature flags, so AFAICT the only option to enable both use cases is to add a separate feature flag for enabling lazy_static/spin_no_std, that is off by default (i.e. std by default, matching the rest of the Rust ecosystem). This is a breaking change (as downstream users depending on that will break) so needs to be released in a 0.6.0 release (which we should do anyway for the MSRV bump).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant