Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to zip32 0.1 #414

Merged
merged 2 commits into from
Jan 11, 2024
Merged

Migrate to zip32 0.1 #414

merged 2 commits into from
Jan 11, 2024

Conversation

str4d
Copy link
Contributor

@str4d str4d commented Jan 10, 2024

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jan 10, 2024

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (4b09ef6) 80.91% compared to head (68290a1) 80.64%.

Files Patch % Lines
src/zip32.rs 56.00% 11 Missing ⚠️
src/keys.rs 28.57% 5 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##           zcash_spec-0.1     #414      +/-   ##
==================================================
- Coverage           80.91%   80.64%   -0.27%     
==================================================
  Files                  30       30              
  Lines                3144     3152       +8     
==================================================
- Hits                 2544     2542       -2     
- Misses                600      610      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

nuttycom
nuttycom previously approved these changes Jan 10, 2024
Copy link
Contributor

@nuttycom nuttycom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 68290a1

Base automatically changed from zcash_spec-0.1 to main January 11, 2024 03:11
@str4d str4d dismissed nuttycom’s stale review January 11, 2024 03:11

The base branch was changed.

Copy link
Contributor

@nuttycom nuttycom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-utACK

@nuttycom nuttycom merged commit c5dea4e into main Jan 11, 2024
27 checks passed
@str4d str4d deleted the zip32-0.1 branch January 11, 2024 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants