Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return bundle metadata from bundle building. #412

Merged
merged 2 commits into from
Jan 9, 2024

Conversation

nuttycom
Copy link
Contributor

@nuttycom nuttycom commented Jan 9, 2024

In order to be able to associate requested spends and outputs with the indices of the actions that execute these operations, it is necessary to track the randomization of inputs and outputs and return the mappings that resulted from that shuffling.

@codecov-commenter
Copy link

codecov-commenter commented Jan 9, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (e127230) 80.99% compared to head (3f7acee) 81.04%.

Files Patch % Lines
src/builder.rs 86.84% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #412      +/-   ##
==========================================
+ Coverage   80.99%   81.04%   +0.05%     
==========================================
  Files          31       31              
  Lines        3146     3166      +20     
==========================================
+ Hits         2548     2566      +18     
- Misses        598      600       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nuttycom nuttycom requested a review from str4d January 9, 2024 21:07
In order to be able to associate requested spends and outputs with the
indices of the actions that execute these operations, it is necessary to
track the randomization of inputs and outputs and return the mappings
that resulted from that shuffling.
str4d
str4d previously approved these changes Jan 9, 2024
Copy link
Contributor

@str4d str4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK b60ef5c with suggestions.

src/builder.rs Outdated Show resolved Hide resolved
src/builder.rs Outdated Show resolved Hide resolved
src/builder.rs Outdated Show resolved Hide resolved
src/builder.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@str4d str4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-utACK 3f7acee

@nuttycom nuttycom merged commit 9a85034 into zcash:main Jan 9, 2024
12 of 13 checks passed
@nuttycom nuttycom deleted the bundle_metadata branch January 9, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants