Merge pull request #425 from zcash/release-0.8.0 #287
Clippy (Stable ~ Linux/x86_64)
Clippy was successful!
Details
Running cargo clippy
took roughly ~17802ms to complete
- Working Directory: repository directory
Annotations
Check warning on line 231 in /home/runner/work/orchard/orchard/src/lib.rs
github-actions / Clippy Result (stable)
/home/runner/work/orchard/orchard/src/lib.rs#L231
the item `RangeConstrained` is imported redundantly
Raw output
warning: the item `RangeConstrained` is imported redundantly
--> src/circuit/commit_ivk.rs:231:80
|
231 | use halo2_gadgets::utilities::{lookup_range_check::LookupRangeCheckConfig, RangeConstrained};
| ^^^^^^^^^^^^^^^^
...
234 | use super::*;
| -------- the item `RangeConstrained` is already imported here
|
= note: `#[warn(unused_imports)]` on by default
Check warning on line 1565 in /home/runner/work/orchard/orchard/src/lib.rs
github-actions / Clippy Result (stable)
/home/runner/work/orchard/orchard/src/lib.rs#L1565
the item `Value` is imported redundantly
Raw output
warning: the item `Value` is imported redundantly
--> src/circuit/note_commit.rs:1565:39
|
1565 | use halo2_proofs::circuit::{Chip, Value};
| ^^^^^
1566 |
1567 | use super::*;
| -------- the item `Value` is already imported here
Check warning on line 6 in /home/runner/work/orchard/orchard/src/lib.rs
github-actions / Clippy Result (stable)
/home/runner/work/orchard/orchard/src/lib.rs#L6
unused import: `H`
Raw output
warning: unused import: `H`
--> src/constants.rs:6:91
|
6 | pub use fixed_bases::{NullifierK, OrchardFixedBases, OrchardFixedBasesFull, ValueCommitV, H};
| ^
Check warning on line 3 in /home/runner/work/orchard/orchard/src/lib.rs
github-actions / Clippy Result (stable)
/home/runner/work/orchard/orchard/src/lib.rs#L3
the item `Ord` is imported redundantly
Raw output
warning: the item `Ord` is imported redundantly
--> src/primitives/redpallas.rs:3:17
|
3 | use core::cmp::{Ord, Ordering, PartialOrd};
| ^^^
--> /rustc/277d06bc95c6c38a2337ccde798b2c709384bd84/library/std/src/prelude/mod.rs:125:13
|
= note: the item `Ord` is already defined here
Check warning on line 3 in /home/runner/work/orchard/orchard/src/lib.rs
github-actions / Clippy Result (stable)
/home/runner/work/orchard/orchard/src/lib.rs#L3
the item `PartialOrd` is imported redundantly
Raw output
warning: the item `PartialOrd` is imported redundantly
--> src/primitives/redpallas.rs:3:32
|
3 | use core::cmp::{Ord, Ordering, PartialOrd};
| ^^^^^^^^^^
--> /rustc/277d06bc95c6c38a2337ccde798b2c709384bd84/library/std/src/prelude/mod.rs:125:13
|
= note: the item `PartialOrd` is already defined here
Check warning on line 534 in /home/runner/work/orchard/orchard/src/lib.rs
github-actions / Clippy Result (stable)
/home/runner/work/orchard/orchard/src/lib.rs#L534
usage of `Iterator::fold` on a type that implements `Try`
Raw output
warning: usage of `Iterator::fold` on a type that implements `Try`
--> src/builder.rs:534:14
|
534 | .fold(Some(ValueSum::zero()), |acc, note_value| acc? + note_value)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `try_fold` instead: `try_fold(ValueSum::zero(), |acc, note_value| ...)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold
= note: `#[warn(clippy::manual_try_fold)]` on by default
Check warning on line 615 in /home/runner/work/orchard/orchard/src/lib.rs
github-actions / Clippy Result (stable)
/home/runner/work/orchard/orchard/src/lib.rs#L615
explicit call to `.into_iter()` in function argument accepting `IntoIterator`
Raw output
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> src/builder.rs:615:18
|
615 | .zip(indexed_outputs.into_iter())
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `indexed_outputs`
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/277d06bc95c6c38a2337ccde798b2c709384bd84/library/core/src/iter/traits/iterator.rs:602:12
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
= note: `#[warn(clippy::useless_conversion)]` on by default
Check warning on line 244 in /home/runner/work/orchard/orchard/src/lib.rs
github-actions / Clippy Result (stable)
/home/runner/work/orchard/orchard/src/lib.rs#L244
explicit call to `.into_iter()` in function argument accepting `IntoIterator`
Raw output
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> src/note_encryption.rs:244:18
|
244 | .zip(ephemeral_keys.into_iter())
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `ephemeral_keys`
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/277d06bc95c6c38a2337ccde798b2c709384bd84/library/core/src/iter/traits/iterator.rs:602:12
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
Check warning on line 195 in /home/runner/work/orchard/orchard/src/lib.rs
github-actions / Clippy Result (stable)
/home/runner/work/orchard/orchard/src/lib.rs#L195
usage of `Iterator::fold` on a type that implements `Try`
Raw output
warning: usage of `Iterator::fold` on a type that implements `Try`
--> src/value.rs:195:14
|
195 | iter.fold(Ok(ValueSum(0)), |acc, v| (acc? + *v).ok_or(OverflowError))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `try_fold` instead: `try_fold(ValueSum(0), |acc, v| ...)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold
Check warning on line 201 in /home/runner/work/orchard/orchard/src/lib.rs
github-actions / Clippy Result (stable)
/home/runner/work/orchard/orchard/src/lib.rs#L201
usage of `Iterator::fold` on a type that implements `Try`
Raw output
warning: usage of `Iterator::fold` on a type that implements `Try`
--> src/value.rs:201:14
|
201 | iter.fold(Ok(ValueSum(0)), |acc, v| (acc? + v).ok_or(OverflowError))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `try_fold` instead: `try_fold(ValueSum(0), |acc, v| ...)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold
Check warning on line 0 in ./file/that/probably/doesnt/exist.rs
github-actions / Clippy Result (stable)
./file/that/probably/doesnt/exist.rs#L0
12 warnings emitted
Raw output
warning: 12 warnings emitted